DescriptionRevert of Keep virtual keyboard visibility the same after enable an IME in a different extension (patchset #6 of https://codereview.chromium.org/487253003/)
Reason for revert:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/33712/steps/memory%20test%3A%20ash_unittests/logs/stdio reports:
UninitCondition
Conditional jump or move depends on uninitialised value(s)
keyboard::KeyboardLayoutManager::SetChildBounds(aura::Window*, gfx::Rect const&) (ui/keyboard/keyboard_layout_manager.cc:53)
aura::Window::SetBounds(gfx::Rect const&) (ui/aura/window.cc:437)
ash::test::VirtualKeyboardRootWindowControllerTest_RestoreWorkspaceAfterLogin_Test::TestBody() (ash/root_window_controller_unittest.cc:738)
UninitCondition
Conditional jump or move depends on uninitialised value(s)
keyboard::KeyboardLayoutManager::SetChildBounds(aura::Window*, gfx::Rect const&) (ui/keyboard/keyboard_layout_manager.cc:53)
aura::Window::SetBounds(gfx::Rect const&) (ui/aura/window.cc:437)
ash::test::VirtualKeyboardRootWindowControllerTest_ClickWithActiveModalDialog_Test::TestBody() (ash/root_window_controller_unittest.cc:771)
UninitCondition
Conditional jump or move depends on uninitialised value(s)
keyboard::KeyboardLayoutManager::SetChildBounds(aura::Window*, gfx::Rect const&) (ui/keyboard/keyboard_layout_manager.cc:53)
aura::Window::SetBounds(gfx::Rect const&) (ui/aura/window.cc:437)
ash::test::VirtualKeyboardRootWindowControllerTest_EnsureCaretInWorkArea_Test::TestBody() (ash/root_window_controller_unittest.cc:827)
Original issue's description:
> Keep virtual keyboard visibility the same after enable an IME in a different extension
>
> BUG=404340
>
> Committed: https://chromium.googlesource.com/chromium/src/+/1d1ac761a3b84652541e8b6e06f3f46450c0f39d
TBR=kevers@chromium.org,oshima@chromium.org,bshe@chromium.org
BUG=404340
Patch Set 1 #
Created: 6 years, 3 months ago
(Patch set is too large to download)
Messages
Total messages: 8 (0 generated)
|