Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 501293002: Revert of Keep virtual keyboard visibility the same after enable an IME in a different extension (Closed)

Created:
6 years, 3 months ago by Jeffrey Yasskin
Modified:
6 years, 3 months ago
Reviewers:
oshima, kevers, bshe
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, Peter Wen
Project:
chromium
Visibility:
Public.

Description

Revert of Keep virtual keyboard visibility the same after enable an IME in a different extension (patchset #6 of https://codereview.chromium.org/487253003/) Reason for revert: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/33712/steps/memory%20test%3A%20ash_unittests/logs/stdio reports: UninitCondition Conditional jump or move depends on uninitialised value(s) keyboard::KeyboardLayoutManager::SetChildBounds(aura::Window*, gfx::Rect const&) (ui/keyboard/keyboard_layout_manager.cc:53) aura::Window::SetBounds(gfx::Rect const&) (ui/aura/window.cc:437) ash::test::VirtualKeyboardRootWindowControllerTest_RestoreWorkspaceAfterLogin_Test::TestBody() (ash/root_window_controller_unittest.cc:738) UninitCondition Conditional jump or move depends on uninitialised value(s) keyboard::KeyboardLayoutManager::SetChildBounds(aura::Window*, gfx::Rect const&) (ui/keyboard/keyboard_layout_manager.cc:53) aura::Window::SetBounds(gfx::Rect const&) (ui/aura/window.cc:437) ash::test::VirtualKeyboardRootWindowControllerTest_ClickWithActiveModalDialog_Test::TestBody() (ash/root_window_controller_unittest.cc:771) UninitCondition Conditional jump or move depends on uninitialised value(s) keyboard::KeyboardLayoutManager::SetChildBounds(aura::Window*, gfx::Rect const&) (ui/keyboard/keyboard_layout_manager.cc:53) aura::Window::SetBounds(gfx::Rect const&) (ui/aura/window.cc:437) ash::test::VirtualKeyboardRootWindowControllerTest_EnsureCaretInWorkArea_Test::TestBody() (ash/root_window_controller_unittest.cc:827) Original issue's description: > Keep virtual keyboard visibility the same after enable an IME in a different extension > > BUG=404340 > > Committed: https://chromium.googlesource.com/chromium/src/+/1d1ac761a3b84652541e8b6e06f3f46450c0f39d TBR=kevers@chromium.org,oshima@chromium.org,bshe@chromium.org BUG=404340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -140 lines) Patch
D chrome/browser/ui/ash/keyboard_controller_browsertest.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_controller.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/keyboard/keyboard_controller.cc View 5 chunks +4 lines, -21 lines 0 comments Download
M ui/keyboard/keyboard_layout_manager.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jeffrey Yasskin
Created Revert of Keep virtual keyboard visibility the same after enable an IME in a ...
6 years, 3 months ago (2014-08-26 01:54:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/501293002/1
6 years, 3 months ago (2014-08-26 01:56:03 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 01:57:37 UTC) #3
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-26 01:57:38 UTC) #4
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 3 months ago (2014-08-26 02:00:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/501293002/1
6 years, 3 months ago (2014-08-26 02:02:10 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-26 02:56:23 UTC) #7
bshe
6 years, 3 months ago (2014-08-26 11:24:58 UTC) #8
Message was sent while issue was closed.
On 2014/08/26 02:56:23, I haz the power (commit-bot) wrote:
> FYI, CQ is re-trying this CL (attempt #1).
> The failing builders are:
>   linux_gpu on tryserver.chromium.gpu
>
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
>   win_gpu on tryserver.chromium.gpu
>
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/51396)
>   linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   linux_chromium_gn_rel on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   linux_chromium_rel_swarming on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   win8_chromium_rel on tryserver.chromium.win
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
>   win_chromium_compile_dbg on tryserver.chromium.win
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
>   win_chromium_rel_swarming on tryserver.chromium.win
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
>   win_chromium_x64_rel_swarming on tryserver.chromium.win
>
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

According to this:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28v...
My later CL (https://codereview.chromium.org/480723006/) fixed the problem. I
tbred you on that CL but you probably missed the review.
I think you probably dont need to revert my CL since the problem is gone. Sorry
for trouble.
my CL and dont need to add suppression.

Powered by Google App Engine
This is Rietveld 408576698