Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1852)

Unified Diff: chrome/browser/extensions/extension_install_prompt.h

Issue 501273002: Update extension install prompt to reflect withheld permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added withheld permissions to install prompt Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_prompt.h
diff --git a/chrome/browser/extensions/extension_install_prompt.h b/chrome/browser/extensions/extension_install_prompt.h
index 54fa47ee81ca1b27736357dbdec3facab34f05e3..8e431592667984afc979c5b9ed44049547ace40c 100644
--- a/chrome/browser/extensions/extension_install_prompt.h
+++ b/chrome/browser/extensions/extension_install_prompt.h
@@ -80,6 +80,7 @@ class ExtensionInstallPrompt
enum DetailsType {
PERMISSIONS_DETAILS = 0,
+ WITHHELD_PERMISSIONS_DETAILS,
RETAINED_FILES_DETAILS,
};
@@ -96,9 +97,11 @@ class ExtensionInstallPrompt
explicit Prompt(PromptType type);
// Sets the permission list for this prompt.
- void SetPermissions(const std::vector<base::string16>& permissions);
+ void SetPermissions(const std::vector<base::string16>& permissions,
+ bool withheld);
// Sets the permission list details for this prompt.
- void SetPermissionsDetails(const std::vector<base::string16>& details);
+ void SetPermissionsDetails(const std::vector<base::string16>& details,
+ bool withheld);
void SetIsShowingDetails(DetailsType type,
size_t index,
bool is_showing_details);
@@ -114,6 +117,7 @@ class ExtensionInstallPrompt
// Getters for UI element labels.
base::string16 GetDialogTitle() const;
base::string16 GetHeading() const;
+ base::string16 GetWithheldHeading() const;
int GetDialogButtons() const;
bool HasAcceptButtonLabel() const;
base::string16 GetAcceptButtonLabel() const;
@@ -140,6 +144,10 @@ class ExtensionInstallPrompt
size_t GetPermissionsDetailsCount() const;
base::string16 GetPermission(size_t index) const;
base::string16 GetPermissionsDetails(size_t index) const;
+ size_t GetWithheldPermissionCount() const;
+ size_t GetWithheldPermissionsDetailsCount() const;
+ base::string16 GetWithheldPermission(size_t index) const;
+ base::string16 GetWithheldPermissionsDetails(size_t index) const;
bool GetIsShowingDetails(DetailsType type, size_t index) const;
size_t GetRetainedFileCount() const;
base::string16 GetRetainedFile(size_t index) const;
@@ -185,8 +193,11 @@ class ExtensionInstallPrompt
// Permissions that are being requested (may not be all of an extension's
// permissions if only additional ones are being requested)
std::vector<base::string16> permissions_;
+ std::vector<base::string16> withheld_permissions_;
std::vector<base::string16> details_;
+ std::vector<base::string16> withheld_details_;
std::vector<bool> is_showing_details_for_permissions_;
+ std::vector<bool> is_showing_details_for_withheld_permissions_;
bool is_showing_details_for_retained_files_;
// The extension or bundle being installed.

Powered by Google App Engine
This is Rietveld 408576698