chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc - Issue 501273002: Update extension install prompt to reflect withheld permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

Issue 501273002: Update extension install prompt to reflect withheld permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cocoa changes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm ('K') | « chrome/browser/ui/views/extensions/extension_install_dialog_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

index 90824b90247cdc66f6ff757a6f9385459c91a05f..de453b773fb4d90425b154a06d223d765ba31667 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

@@ -128,12 +128,14 @@ void ExtensionInstallDialogViewTestBase::SetUpOnMainThread() {

void ExtensionInstallDialogViewTestBase::SetPromptPermissions(

std::vector<base::string16> permissions) {

- prompt_->SetPermissions(permissions);

+ prompt_->SetPermissions(permissions,

+ ExtensionInstallPrompt::REGULAR_PERMISSIONS);

}

void ExtensionInstallDialogViewTestBase::SetPromptDetails(

std::vector<base::string16> details) {

- prompt_->SetPermissionsDetails(details);

+ prompt_->SetPermissionsDetails(details,

+ ExtensionInstallPrompt::REGULAR_PERMISSIONS);

}

void ExtensionInstallDialogViewTestBase::SetPromptRetainedFiles(