Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6678)

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.h

Issue 501273002: Update extension install prompt to reflect withheld permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.h
diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.h b/chrome/browser/ui/views/extensions/extension_install_dialog_view.h
index 604e9ae1e6a874f6398f10cf122b2137550e71d7..a93508999089746dc2e374c8b77a3802cf6f6e28 100644
--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.h
+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.h
@@ -24,6 +24,10 @@ namespace extensions {
class ExperienceSamplingEvent;
}
+namespace ui {
+class ResourceBundle;
+}
+
namespace views {
class GridLayout;
class ImageButton;
@@ -86,6 +90,16 @@ class ExtensionInstallDialogView : public views::DialogDelegateView,
// Experimental: Toggles inline permission explanations with an animation.
void ToggleInlineExplanations();
+ // Initializes the dialog view, adding in permissions if they exist.
+ void InitView();
+
+ // Adds permissions of |perm_type| to the dialog view if they exist.
+ bool MaybeAddPermissions(views::GridLayout* layout,
Devlin 2014/09/04 22:06:09 I would just call this AddPermissions(). The comm
gpdavis 2014/09/05 20:23:02 Done.
+ ui::ResourceBundle& rb,
+ int column_set_id,
+ int left_column_width,
+ ExtensionInstallPrompt::PermissionsType perm_type);
+
// Creates a layout consisting of dialog header, extension name and icon.
views::GridLayout* CreateLayout(
views::View* parent,

Powered by Google App Engine
This is Rietveld 408576698