Update extension install prompt to reflect withheld permissions

chrome/browser/extensions/extension_install_prompt.h

Index: chrome/browser/extensions/extension_install_prompt.h
diff --git a/chrome/browser/extensions/extension_install_prompt.h b/chrome/browser/extensions/extension_install_prompt.h
index 54fa47ee81ca1b27736357dbdec3facab34f05e3..ec2a024f8eedb6085e244494900cab2ab8129ff6 100644
--- a/chrome/browser/extensions/extension_install_prompt.h
+++ b/chrome/browser/extensions/extension_install_prompt.h
@@ -80,9 +80,16 @@ class ExtensionInstallPrompt
 
   enum DetailsType {
     PERMISSIONS_DETAILS = 0,
+    WITHHELD_PERMISSIONS_DETAILS,
     RETAINED_FILES_DETAILS,
   };
 
+  enum PermissionsType {
+    REGULAR_PERMISSIONS = 0,
+    WITHHELD_PERMISSIONS,
+    ALL_PERMISSIONS,
+  };
+
   static std::string PromptTypeToString(PromptType type);
 
   // Extra information needed to display an installation or uninstallation
@@ -96,9 +103,11 @@ class ExtensionInstallPrompt
     explicit Prompt(PromptType type);
 
     // Sets the permission list for this prompt.
-    void SetPermissions(const std::vector<base::string16>& permissions);
+    void SetPermissions(const std::vector<base::string16>& permissions,
+                        PermissionsType permissions_type);
     // Sets the permission list details for this prompt.
-    void SetPermissionsDetails(const std::vector<base::string16>& details);
+    void SetPermissionsDetails(const std::vector<base::string16>& details,
+                               PermissionsType permissions_type);
     void SetIsShowingDetails(DetailsType type,
                              size_t index,
                              bool is_showing_details);
@@ -119,7 +128,8 @@ class ExtensionInstallPrompt
     base::string16 GetAcceptButtonLabel() const;
     bool HasAbortButtonLabel() const;
     base::string16 GetAbortButtonLabel() const;
-    base::string16 GetPermissionsHeading() const;
+    base::string16 GetPermissionsHeading(
+        PermissionsType permissions_type) const;
     base::string16 GetRetainedFilesHeading() const;
 
     bool ShouldShowPermissions() const;
@@ -136,10 +146,13 @@ class ExtensionInstallPrompt
     void AppendRatingStars(StarAppender appender, void* data) const;
     base::string16 GetRatingCount() const;
     base::string16 GetUserCount() const;
-    size_t GetPermissionCount() const;
-    size_t GetPermissionsDetailsCount() const;
-    base::string16 GetPermission(size_t index) const;
-    base::string16 GetPermissionsDetails(size_t index) const;
+    size_t GetPermissionCount(PermissionsType permissions_type) const;
+    size_t GetPermissionsDetailsCount(PermissionsType permissions_type) const;
+    base::string16 GetPermission(size_t index,
+                                 PermissionsType permissions_type) const;
+    base::string16 GetPermissionsDetails(
+        size_t index,
+        PermissionsType permissions_type) const;
     bool GetIsShowingDetails(DetailsType type, size_t index) const;
     size_t GetRetainedFileCount() const;
     base::string16 GetRetainedFile(size_t index) const;
@@ -185,8 +198,11 @@ class ExtensionInstallPrompt
     // Permissions that are being requested (may not be all of an extension's
     // permissions if only additional ones are being requested)
     std::vector<base::string16> permissions_;
+    std::vector<base::string16> withheld_permissions_;

[Devlin, 2014/09/02 21:07:51]

maybe a struct for these, and then one for withheld and one for regular?

[gpdavis, 2014/09/04 19:40:04]

Sure.  It's a complex struct, though, so it requires an out of line constructor.
 Does this belong in the cc file, or below the struct definition in the header?

[Devlin, 2014/09/04 22:06:08]

in the cc file.

     std::vector<base::string16> details_;
+    std::vector<base::string16> withheld_details_;
     std::vector<bool> is_showing_details_for_permissions_;
+    std::vector<bool> is_showing_details_for_withheld_permissions_;
     bool is_showing_details_for_retained_files_;
 
     // The extension or bundle being installed.