Update extension install prompt to reflect withheld permissions

chrome/browser/extensions/permissions_updater.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_PERMISSIONS_UPDATER_H__
 #define CHROME_BROWSER_EXTENSIONS_PERMISSIONS_UPDATER_H__
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
 
 namespace base {
 class DictionaryValue;
 }
 
 namespace content {
 class BrowserContext;
 }
 
 namespace extensions {
 
 class Extension;
 class ExtensionPrefs;
 class PermissionSet;
 
 // Updates an Extension's active and granted permissions in persistent storage
 // and notifies interested parties of the changes.
 class PermissionsUpdater {
  public:
+  enum InitFlag {
+    INIT_FLAG_NONE = 0,
+    INIT_FLAG_TRANSIENT = 1 << 0,
+  };
+
   explicit PermissionsUpdater(content::BrowserContext* browser_context);
+  explicit PermissionsUpdater(content::BrowserContext* browser_context,

[Devlin, 2014/09/11 21:18:53]

This doesn't need explicit anymore :)

[gpdavis, 2014/09/12 00:11:54]

Ah, okay, we just need explicit for single parameter constructors, correct?

[Devlin, 2014/09/12 00:26:46]

Right.  This stack overflow question does a good job of explaining. [1]  But
basically, explicit means that, if an object's constructor takes a single second
object, given that single object, you can implicitly convert to the first
object.  Very bad in the case of, say, a Browser object (which only needs a
Profile).

[1]
http://stackoverflow.com/questions/121162/what-does-the-explicit-keyword-in-c...

[gpdavis, 2014/09/12 00:30:57]

Yep, I found that with a quick google search :)  Just wanted to clarify that
that's something we always do for single parameter constructors.

+                              InitFlag init_flag);
   ~PermissionsUpdater();
 
   // Adds the set of |permissions| to the |extension|'s active permission set
   // and sends the relevant messages and notifications. This method assumes the
   // user has already been prompted, if necessary, for the extra permissions.
   void AddPermissions(const Extension* extension,
                       const PermissionSet* permissions);
 
   // Removes the set of |permissions| from the |extension|'s active permission
   // set and sends the relevant messages and notifications.
@@ skipping 38 matching lines @@
   // |extension|'s permissions have |changed| (|changed| is the delta).
   // Specifically, this sends the EXTENSION_PERMISSIONS_UPDATED notification,
   // the ExtensionMsg_UpdatePermissions IPC message, and fires the
   // onAdded/onRemoved events in the extension.
   void NotifyPermissionsUpdated(EventType event_type,
                                 const Extension* extension,
                                 const PermissionSet* changed);
 
   // The associated BrowserContext.
   content::BrowserContext* browser_context_;
+
+  InitFlag init_flag_;

[Devlin, 2014/09/11 21:18:53]

Comment.

[gpdavis, 2014/09/12 00:11:54]

Done.

 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_PERMISSIONS_UPDATER_H__