Update extension install prompt to reflect withheld permissions

chrome/browser/ui/views/extensions/extension_install_dialog_view.h

 // Copyright 2014 The Chromium Authors. All rights reserved.

[Devlin, 2014/09/02 21:07:51]

(comment inserted at random location)
I think there's also a mac version of this dialog that will need to be updated.

[gpdavis, 2014/09/04 19:40:04]

Yep; I'm aware of the cocoa file for this as well.  I'll go ahead and make the
changes there as well.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_INSTALL_DIALOG_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_INSTALL_DIALOG_VIEW_H_
 
 #include "chrome/browser/extensions/extension_install_prompt.h"
+#include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/animation/animation_delegate.h"
 #include "ui/gfx/animation/slide_animation.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/link_listener.h"
 #include "ui/views/view.h"
 #include "ui/views/window/dialog_delegate.h"
 
 typedef std::vector<base::string16> PermissionDetails;
 class ExpandableContainerView;
 
@@ skipping 28 matching lines @@
 class ExtensionInstallDialogView : public views::DialogDelegateView,
                                    public views::LinkListener,
                                    public views::ButtonListener {
  public:
   ExtensionInstallDialogView(
       content::PageNavigator* navigator,
       ExtensionInstallPrompt::Delegate* delegate,
       scoped_refptr<ExtensionInstallPrompt::Prompt> prompt);
   virtual ~ExtensionInstallDialogView();
 
+  void InitView();

[Devlin, 2014/09/02 21:07:51]

Comments.

[gpdavis, 2014/09/04 19:40:04]

Wasn't sure what to say about this, since there weren't previously any comments
about it and I didn't want to be redundant.  How about something like
"Initializes the dialogue view, adding in permissions if they exist."?  I kind
of feel like that doesn't say very much, but I don't want to be overly verbose
either.  Advice?

+
+  bool MaybeAddPermissions(views::GridLayout* layout,

[Devlin, 2014/09/02 21:07:51]

Is there a reason these two functions should be public?

[Devlin, 2014/09/02 21:07:51]

Comments

[gpdavis, 2014/09/04 19:40:04]

No there is not.  My mistake.  Done.

[gpdavis, 2014/09/04 19:40:04]

How about...

"Adds permissions of |perm_type| to the dialogue view if they exist." ?

+                           ui::ResourceBundle& rb,

[Devlin, 2014/09/02 21:07:51]

Just forward-declare resource bundle, rather than include it.

[gpdavis, 2014/09/04 19:40:04]

Done.

+                           int column_set_id,
+                           int left_column_width,
+                           ExtensionInstallPrompt::PermissionsType perm_type);
+
   // Returns the interior ScrollView of the dialog. This allows us to inspect
   // the contents of the DialogView.
   const views::ScrollView* scroll_view() const { return scroll_view_; }
 
   // Called when one of the child elements has expanded/collapsed.
   void ContentsChanged();
 
  private:
   // views::DialogDelegateView:
   virtual int GetDialogButtons() const OVERRIDE;
@@ skipping 187 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ExpandableContainerView);
 };
 
 void ShowExtensionInstallDialogImpl(
     const ExtensionInstallPrompt::ShowParams& show_params,
     ExtensionInstallPrompt::Delegate* delegate,
     scoped_refptr<ExtensionInstallPrompt::Prompt> prompt);
 
 #endif  // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_INSTALL_DIALOG_VIEW_H_