Update extension install prompt to reflect withheld permissions

chrome/browser/extensions/extension_install_prompt.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_prompt.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/bundle_installer.h"
 #include "chrome/browser/extensions/extension_install_ui.h"
 #include "chrome/browser/extensions/extension_util.h"
+#include "chrome/browser/extensions/permissions_updater.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_util.h"
@@ skipping 183 matching lines @@
       average_rating_(0.0),
       rating_count_(0),
       show_user_count_(false),
       has_webstore_data_(false) {
 }
 
 ExtensionInstallPrompt::Prompt::~Prompt() {
 }
 
 void ExtensionInstallPrompt::Prompt::SetPermissions(
-    const std::vector<base::string16>& permissions) {
-  permissions_ = permissions;
+    const std::vector<base::string16>& permissions,
+    PermissionsType permissions_type) {
+  switch (permissions_type) {
+    case REGULAR_PERMISSIONS:
+      permissions_ = permissions;
+      break;
+    case WITHHELD_PERMISSIONS:
+      withheld_permissions_ = permissions;
+      break;
+    case ALL_PERMISSIONS:
+      NOTREACHED();
+      break;
+  }
 }
 
 void ExtensionInstallPrompt::Prompt::SetPermissionsDetails(
-    const std::vector<base::string16>& details) {
-  details_ = details;
-  is_showing_details_for_permissions_.clear();
-  for (size_t i = 0; i < details.size(); ++i)
-    is_showing_details_for_permissions_.push_back(false);
+    const std::vector<base::string16>& details,
+    PermissionsType permissions_type) {
+  switch (permissions_type) {
+    case REGULAR_PERMISSIONS:
+      details_ = details;
+      is_showing_details_for_permissions_.clear();
+      for (size_t i = 0; i < details.size(); ++i)
+        is_showing_details_for_permissions_.push_back(false);
+      break;
+    case WITHHELD_PERMISSIONS:
+      withheld_details_ = details;
+      is_showing_details_for_withheld_permissions_.clear();
+      for (size_t i = 0; i < details.size(); ++i)
+        is_showing_details_for_withheld_permissions_.push_back(false);
+      break;
+    case ALL_PERMISSIONS:
+      NOTREACHED();
+      break;
+  }
 }
 
 void ExtensionInstallPrompt::Prompt::SetIsShowingDetails(
     DetailsType type,
     size_t index,
     bool is_showing_details) {
   switch (type) {
     case PERMISSIONS_DETAILS:
       is_showing_details_for_permissions_[index] = is_showing_details;
       break;
+    case WITHHELD_PERMISSIONS_DETAILS:
+      is_showing_details_for_withheld_permissions_[index] = is_showing_details;
+      break;
     case RETAINED_FILES_DETAILS:
       is_showing_details_for_retained_files_ = is_showing_details;
       break;
   }
 }
 
 void ExtensionInstallPrompt::Prompt::SetWebstoreData(
     const std::string& localized_user_count,
     bool show_user_count,
     double average_rating,
@@ skipping 95 matching lines @@
   return kAbortButtonIds[type_] > 0;
 }
 
 base::string16 ExtensionInstallPrompt::Prompt::GetAbortButtonLabel() const {
   CHECK(HasAbortButtonLabel());
   if (ShouldShowExplanationText())
     return experiment_->GetCancelButtonText();
   return l10n_util::GetStringUTF16(kAbortButtonIds[type_]);
 }
 
-base::string16 ExtensionInstallPrompt::Prompt::GetPermissionsHeading() const {
-  return l10n_util::GetStringUTF16(kPermissionsHeaderIds[type_]);
+base::string16 ExtensionInstallPrompt::Prompt::GetPermissionsHeading(
+    PermissionsType permissions_type) const {
+  switch (permissions_type) {
+    case REGULAR_PERMISSIONS:
+      return l10n_util::GetStringUTF16(kPermissionsHeaderIds[type_]);
+    case WITHHELD_PERMISSIONS:
+      return l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WITHHELD);
+    case ALL_PERMISSIONS:
+      NOTREACHED();
+      return base::string16();
+  }
 }
 
 base::string16 ExtensionInstallPrompt::Prompt::GetRetainedFilesHeading() const {
   const int kRetainedFilesMessageIDs[6] = {
       IDS_EXTENSION_PROMPT_RETAINED_FILES_DEFAULT,
       IDS_EXTENSION_PROMPT_RETAINED_FILE_SINGULAR,
       IDS_EXTENSION_PROMPT_RETAINED_FILES_ZERO,
       IDS_EXTENSION_PROMPT_RETAINED_FILES_TWO,
       IDS_EXTENSION_PROMPT_RETAINED_FILES_FEW,
       IDS_EXTENSION_PROMPT_RETAINED_FILES_MANY,
   };
   std::vector<int> message_ids;
   for (size_t i = 0; i < arraysize(kRetainedFilesMessageIDs); i++) {
     message_ids.push_back(kRetainedFilesMessageIDs[i]);
   }
   return l10n_util::GetPluralStringFUTF16(message_ids, GetRetainedFileCount());
 }
 
 bool ExtensionInstallPrompt::Prompt::ShouldShowPermissions() const {
-  return GetPermissionCount() > 0 || type_ == POST_INSTALL_PERMISSIONS_PROMPT;
+  return GetPermissionCount(REGULAR_PERMISSIONS) > 0 ||
+         GetPermissionCount(WITHHELD_PERMISSIONS) > 0 ||
+         type_ == POST_INSTALL_PERMISSIONS_PROMPT;
 }
 
 void ExtensionInstallPrompt::Prompt::AppendRatingStars(
     StarAppender appender, void* data) const {
   CHECK(appender);
   CHECK(type_ == INLINE_INSTALL_PROMPT || type_ == EXTERNAL_INSTALL_PROMPT);
   int rating_integer = floor(average_rating_);
   double rating_fractional = average_rating_ - rating_integer;
 
   if (rating_fractional > 0.66) {
@@ skipping 27 matching lines @@
 base::string16 ExtensionInstallPrompt::Prompt::GetUserCount() const {
   CHECK(type_ == INLINE_INSTALL_PROMPT || type_ == EXTERNAL_INSTALL_PROMPT);
 
   if (show_user_count_) {
     return l10n_util::GetStringFUTF16(IDS_EXTENSION_USER_COUNT,
                                       base::UTF8ToUTF16(localized_user_count_));
   }
   return base::string16();
 }
 
-size_t ExtensionInstallPrompt::Prompt::GetPermissionCount() const {
-  return permissions_.size();
+size_t ExtensionInstallPrompt::Prompt::GetPermissionCount(
+    PermissionsType permissions_type) const {
+  switch (permissions_type) {
+    case REGULAR_PERMISSIONS:
+      return permissions_.size();
+    case WITHHELD_PERMISSIONS:
+      return withheld_permissions_.size();
+    case ALL_PERMISSIONS:
+      return permissions_.size() + withheld_permissions_.size();
+  }
 }
 
-size_t ExtensionInstallPrompt::Prompt::GetPermissionsDetailsCount() const {
-  return details_.size();
+size_t ExtensionInstallPrompt::Prompt::GetPermissionsDetailsCount(
+    PermissionsType permissions_type) const {
+  switch (permissions_type) {
+    case REGULAR_PERMISSIONS:
+      return details_.size();
+    case WITHHELD_PERMISSIONS:
+      return withheld_details_.size();
+    case ALL_PERMISSIONS:
+      return details_.size() + withheld_details_.size();
+  }
 }
 
-base::string16 ExtensionInstallPrompt::Prompt::GetPermission(size_t index)
-    const {
-  CHECK_LT(index, permissions_.size());
-  return permissions_[index];
+base::string16 ExtensionInstallPrompt::Prompt::GetPermission(
+    size_t index,
+    PermissionsType permissions_type) const {
+  switch (permissions_type) {
+    case REGULAR_PERMISSIONS:
+      CHECK_LT(index, permissions_.size());
+      return permissions_[index];
+    case WITHHELD_PERMISSIONS:
+      CHECK_LT(index, withheld_permissions_.size());
+      return withheld_permissions_[index];
+    case ALL_PERMISSIONS:
+      NOTREACHED();
+      return base::string16();
+  }
 }
 
 base::string16 ExtensionInstallPrompt::Prompt::GetPermissionsDetails(
-    size_t index) const {
-  CHECK_LT(index, details_.size());
-  return details_[index];
+    size_t index,
+    PermissionsType permissions_type) const {
+  switch (permissions_type) {
+    case REGULAR_PERMISSIONS:
+      CHECK_LT(index, details_.size());
+      return details_[index];
+    case WITHHELD_PERMISSIONS:
+      CHECK_LT(index, withheld_details_.size());
+      return withheld_details_[index];
+    case ALL_PERMISSIONS:
+      NOTREACHED();
+      return base::string16();
+  }
 }
 
 bool ExtensionInstallPrompt::Prompt::GetIsShowingDetails(
     DetailsType type, size_t index) const {
   switch (type) {
     case PERMISSIONS_DETAILS:
       CHECK_LT(index, is_showing_details_for_permissions_.size());
       return is_showing_details_for_permissions_[index];
+    case WITHHELD_PERMISSIONS_DETAILS:
+      CHECK_LT(index, is_showing_details_for_withheld_permissions_.size());
+      return is_showing_details_for_withheld_permissions_[index];
     case RETAINED_FILES_DETAILS:
       return is_showing_details_for_retained_files_;
   }
   return false;
 }
 
 size_t ExtensionInstallPrompt::Prompt::GetRetainedFileCount() const {
   return retained_files_.size();
 }
 
@@ skipping 278 matching lines @@
     prompt_->set_experiment(ExtensionInstallPromptExperiment::ControlGroup());
 
   if (permissions_.get() &&
       (!extension_ ||
        !extensions::PermissionsData::ShouldSkipPermissionWarnings(
            extension_->id()))) {
     Manifest::Type type =
         extension_ ? extension_->GetType() : Manifest::TYPE_UNKNOWN;
     const extensions::PermissionMessageProvider* message_provider =
         extensions::PermissionMessageProvider::Get();
+
+    // Initialize permissions so that withheld permissions don't end up in the
+    // install prompt.
+    if (extension_) {
+      extensions::PermissionsUpdater(install_ui_->profile())
+          .InitializePermissions(
+              extension_, extensions::PermissionsUpdater::INIT_FLAG_TRANSIENT);
+      permissions_ = extension_->permissions_data()->active_permissions();

[Devlin, 2014/09/02 21:07:51]

This will fantastically break optional permissions' use of the install prompt.

OptionalPermissions creates an install prompt and sets its extension and
permissions, but the permissions will be set to the *desired* permissions, not
to the existing permissions. [1]  As such, we need to (in some cases) respect
the |permissions_| which were set earlier.

[gpdavis, 2014/09/04 19:40:04]

Okay, I think I figured this out.  I've removed the permissions_ setters that
just use active permissions, and instead, I added logic that will initialize
permissions and set permissions_ if permissions_ hasn't already been set.  This
way, special cases can manually set permissions_ before ShowConfirmation is
called, and they won't get overridden.

Can you think of any issues that might arise from this implementation?

+    }
     prompt_->SetPermissions(
-        message_provider->GetWarningMessages(permissions_.get(), type));
+        message_provider->GetWarningMessages(permissions_.get(), type),
+        REGULAR_PERMISSIONS);
     prompt_->SetPermissionsDetails(
-        message_provider->GetWarningMessagesDetails(permissions_.get(), type));
+        message_provider->GetWarningMessagesDetails(permissions_.get(), type),
+        REGULAR_PERMISSIONS);
+
+    scoped_refptr<const extensions::PermissionSet> withheld =
+        extension_->permissions_data()->withheld_permissions();
+    if (!withheld->IsEmpty()) {
+      prompt_->SetPermissions(
+          message_provider->GetWarningMessages(withheld.get(), type),
+          PermissionsType::WITHHELD_PERMISSIONS);
+      prompt_->SetPermissionsDetails(
+          message_provider->GetWarningMessagesDetails(withheld.get(), type),
+          PermissionsType::WITHHELD_PERMISSIONS);
+    }
   }
 
   switch (prompt_->type()) {
     case PERMISSIONS_PROMPT:
     case RE_ENABLE_PROMPT:
     case INLINE_INSTALL_PROMPT:
     case EXTERNAL_INSTALL_PROMPT:
     case INSTALL_PROMPT:
     case LAUNCH_PROMPT:
     case POST_INSTALL_PERMISSIONS_PROMPT:
@@ skipping 12 matching lines @@
   }
 
   if (AutoConfirmPrompt(delegate_))
     return;
 
   if (show_dialog_callback_.is_null())
     GetDefaultShowDialogCallback().Run(show_params_, delegate_, prompt_);
   else
     show_dialog_callback_.Run(show_params_, delegate_, prompt_);
 }