Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6208)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 501263002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Just in case Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index 66915fe64be7e44c268fc47a218a7d48e4b1c261..8dd85b1230b241b0c4b7e75ad5d026941ce22c4e 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -548,10 +548,10 @@ bool WebstorePrivateCompleteInstallFunction::RunAsync() {
// downloading from the Web Store is not necessary.
const Extension* extension = ExtensionRegistry::Get(GetProfile())->
GetExtensionById(params->expected_id, ExtensionRegistry::EVERYTHING);
- if (extension && approval_->dummy_extension &&
+ if (extension && approval_->dummy_extension.get() &&
util::IsEphemeralApp(extension->id(), GetProfile()) &&
- extension->version()->CompareTo(
- *approval_->dummy_extension->version()) >= 0) {
+ extension->version()->CompareTo(*approval_->dummy_extension->version()) >=
+ 0) {
install_ui::ShowPostInstallUIForApproval(
GetProfile(), *approval_, extension);

Powered by Google App Engine
This is Rietveld 408576698