Issue 50123006: Let TextTrackResource be a RawResource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 50123006: Let TextTrackResource be a RawResource (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin, abarth-chromium

CC:
blink-reviews, Nate Chapin, nessy, vcarbune.chromium, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Let TextTrackResource be a RawResource This allows deprecatedDidReceiveResource to be removed completely, by using the exising appendData callback instead. The removed FIXME was a little bit confused, in that it didn't seem to realize that incremental parsing is needed for WebVTT. Also add OVERRIDE where possible. BUG=312756 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160848

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -25 lines)			Patch
M	Source/core/fetch/ResourceClient.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/fetch/TextTrackResource.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	Source/core/fetch/TextTrackResource.cpp	View	2 chunks	+1 line, -10 lines	0 comments	Download
M	Source/core/loader/TextTrackLoader.h	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	Source/core/loader/TextTrackLoader.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

This is part 1 of 2. If it looks OK, I'll also do the CL ...

7 years, 1 month ago (2013-10-29 15:02:31 UTC) #1

philipj_slow

On 2013/10/29 16:10:13, Nate Chapin wrote: > LGTM! > > Looking forward to part 2 ...

7 years, 1 month ago (2013-10-29 16:17:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/50123006/1

7 years, 1 month ago (2013-10-29 16:17:48 UTC) #4

Message was sent while issue was closed.

Change committed as 160848

Expand Messages | Collapse Messages