Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 501213002: Update codec tests for Android. (Closed)

Created:
6 years, 4 months ago by Raymond Toy
Modified:
6 years, 3 months ago
Reviewers:
DaleCurtis
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Update codec tests for Android. I verified manually that the new files differ from the original expected results by a few bits. I did not investigate the underlying cause for the difference, but I suspect some changes in ffmpeg is causing these differences. Android was using the linux files for the expected results so changes in ffmpeg can cause Android results to differ since WebAudio uses Android's MediaCodec framework to decode audio files. BUG=407368 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181831

Patch Set 1 #

Messages

Total messages: 11 (1 generated)
Raymond Toy
rtoy@chromium.org changed reviewers: + dalecurtis@chromium.org
6 years, 3 months ago (2014-08-26 16:54:12 UTC) #1
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
6 years, 3 months ago (2014-08-26 16:54:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@chromium.org/501213002/1
6 years, 3 months ago (2014-08-26 16:56:09 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 3 months ago (2014-08-26 18:03:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 19:13:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/24390)
6 years, 3 months ago (2014-08-26 19:13:27 UTC) #6
DaleCurtis
Wait, android doesn't use ffmpeg I thought...
6 years, 3 months ago (2014-08-26 19:39:12 UTC) #7
DaleCurtis
Durr, I should read the description first. lgtm
6 years, 3 months ago (2014-08-26 19:43:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/501213002/1
6 years, 3 months ago (2014-09-11 16:21:16 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 16:55:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181831

Powered by Google App Engine
This is Rietveld 408576698