Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: content/browser/indexed_db/indexed_db_factory_unittest.cc

Issue 501183003: Remove implicit conversions from scoped_refptr to T* in content/browser/indexed_db/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_factory_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_factory_unittest.cc b/content/browser/indexed_db/indexed_db_factory_unittest.cc
index f61d9750304333f5323090ce54fe4c1f600c85aa..402c383782bd269208199861c0bafb33e2f329cb 100644
--- a/content/browser/indexed_db/indexed_db_factory_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_factory_unittest.cc
@@ -110,8 +110,8 @@ TEST_F(IndexedDBFactoryTest, BackingStoreLifetime) {
scoped_refptr<IndexedDBBackingStore> disk_store3 =
factory()->TestOpenBackingStore(origin2, temp_directory.path());
- factory()->TestCloseBackingStore(disk_store1);
- factory()->TestCloseBackingStore(disk_store3);
+ factory()->TestCloseBackingStore(disk_store1.get());
+ factory()->TestCloseBackingStore(disk_store3.get());
EXPECT_FALSE(disk_store1->HasOneRef());
EXPECT_FALSE(disk_store2->HasOneRef());
@@ -163,8 +163,8 @@ TEST_F(IndexedDBFactoryTest, MemoryBackingStoreLifetime) {
scoped_refptr<IndexedDBBackingStore> mem_store3 =
factory()->TestOpenBackingStore(origin2, base::FilePath());
- factory()->TestCloseBackingStore(mem_store1);
- factory()->TestCloseBackingStore(mem_store3);
+ factory()->TestCloseBackingStore(mem_store1.get());
+ factory()->TestCloseBackingStore(mem_store3.get());
EXPECT_FALSE(mem_store1->HasOneRef());
EXPECT_FALSE(mem_store2->HasOneRef());
@@ -191,12 +191,12 @@ TEST_F(IndexedDBFactoryTest, RejectLongOrigins) {
GURL too_long_origin("http://" + origin + ":81/");
scoped_refptr<IndexedDBBackingStore> diskStore1 =
factory()->TestOpenBackingStore(too_long_origin, base_path);
- EXPECT_FALSE(diskStore1);
+ EXPECT_FALSE(diskStore1.get());
GURL ok_origin("http://someorigin.com:82/");
scoped_refptr<IndexedDBBackingStore> diskStore2 =
factory()->TestOpenBackingStore(ok_origin, base_path);
- EXPECT_TRUE(diskStore2);
+ EXPECT_TRUE(diskStore2.get());
}
class DiskFullFactory : public IndexedDBFactoryImpl {
« no previous file with comments | « content/browser/indexed_db/indexed_db_factory_impl.cc ('k') | content/browser/indexed_db/indexed_db_internals_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698