Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Unified Diff: content/browser/indexed_db/indexed_db_database_unittest.cc

Issue 501183003: Remove implicit conversions from scoped_refptr to T* in content/browser/indexed_db/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_database_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_database_unittest.cc b/content/browser/indexed_db/indexed_db_database_unittest.cc
index 5bea05929932168025be378d1c4be1798a7e048d..0f4134c96d8f702b44dd3eadadd6e1ae0c1bc113 100644
--- a/content/browser/indexed_db/indexed_db_database_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_database_unittest.cc
@@ -41,8 +41,8 @@ TEST(IndexedDBDatabaseTest, BackingStoreRetention) {
leveldb::Status s;
scoped_refptr<IndexedDBDatabase> db =
IndexedDBDatabase::Create(ASCIIToUTF16("db"),
- backing_store,
- factory,
+ backing_store.get(),
+ factory.get(),
IndexedDBDatabase::Identifier(),
&s);
ASSERT_TRUE(s.ok());
@@ -60,8 +60,8 @@ TEST(IndexedDBDatabaseTest, ConnectionLifecycle) {
leveldb::Status s;
scoped_refptr<IndexedDBDatabase> db =
IndexedDBDatabase::Create(ASCIIToUTF16("db"),
- backing_store,
- factory,
+ backing_store.get(),
+ factory.get(),
IndexedDBDatabase::Identifier(),
&s);
ASSERT_TRUE(s.ok());
@@ -118,8 +118,8 @@ TEST(IndexedDBDatabaseTest, ForcedClose) {
leveldb::Status s;
scoped_refptr<IndexedDBDatabase> database =
IndexedDBDatabase::Create(ASCIIToUTF16("db"),
- backing_store,
- factory,
+ backing_store.get(),
+ factory.get(),
IndexedDBDatabase::Identifier(),
&s);
ASSERT_TRUE(s.ok());
@@ -136,7 +136,7 @@ TEST(IndexedDBDatabaseTest, ForcedClose) {
upgrade_transaction_id,
IndexedDBDatabaseMetadata::DEFAULT_INT_VERSION);
database->OpenConnection(connection);
- EXPECT_EQ(database, request->connection()->database());
+ EXPECT_EQ(database.get(), request->connection()->database());
const int64 transaction_id = 123;
const std::vector<int64> scope;
@@ -184,8 +184,8 @@ TEST(IndexedDBDatabaseTest, PendingDelete) {
leveldb::Status s;
scoped_refptr<IndexedDBDatabase> db =
IndexedDBDatabase::Create(ASCIIToUTF16("db"),
- backing_store,
- factory,
+ backing_store.get(),
+ factory.get(),
IndexedDBDatabase::Identifier(),
&s);
ASSERT_TRUE(s.ok());
@@ -234,8 +234,8 @@ class IndexedDBDatabaseOperationTest : public testing::Test {
backing_store_ = new IndexedDBFakeBackingStore();
leveldb::Status s;
db_ = IndexedDBDatabase::Create(ASCIIToUTF16("db"),
- backing_store_,
- factory_,
+ backing_store_.get(),
+ factory_.get(),
IndexedDBDatabase::Identifier(),
&s);
ASSERT_TRUE(s.ok());
@@ -257,9 +257,9 @@ class IndexedDBDatabaseOperationTest : public testing::Test {
callbacks_,
std::set<int64>() /*scope*/,
blink::WebIDBTransactionModeVersionChange,
- db_,
+ db_.get(),
new IndexedDBFakeBackingStore::FakeTransaction(commit_success_));
- db_->TransactionCreated(transaction_);
+ db_->TransactionCreated(transaction_.get());
// Add a dummy task which takes the place of the VersionChangeOperation
// which kicks off the upgrade. This ensures that the transaction has
« no previous file with comments | « content/browser/indexed_db/indexed_db_database.cc ('k') | content/browser/indexed_db/indexed_db_dispatcher_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698