Remove implicit conversions from scoped_refptr to T* in content/browser/indexed_db/

content/browser/indexed_db/indexed_db_backing_store_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
 
 #include "base/callback.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/logging.h"
@@ skipping 217 matching lines @@
 
 class IndexedDBBackingStoreTest : public testing::Test {
  public:
   IndexedDBBackingStoreTest() {}
   virtual void SetUp() {
     const GURL origin("http://localhost:81");
     task_runner_ = new base::TestSimpleTaskRunner();
     special_storage_policy_ = new MockSpecialStoragePolicy();
     special_storage_policy_->SetAllUnlimited(true);
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
-    idb_context_ = new IndexedDBContextImpl(
-        temp_dir_.path(), special_storage_policy_, NULL, task_runner_);
-    idb_factory_ = new TestIDBFactory(idb_context_);
+    idb_context_ = new IndexedDBContextImpl(temp_dir_.path(),
+                                            special_storage_policy_.get(),
+                                            NULL,
+                                            task_runner_.get());
+    idb_factory_ = new TestIDBFactory(idb_context_.get());
     backing_store_ =
         idb_factory_->OpenBackingStoreForTest(origin, &url_request_context_);
 
     // useful keys and values during tests
     m_value1 = IndexedDBValue("value1", std::vector<IndexedDBBlobInfo>());
     m_value2 = IndexedDBValue("value2", std::vector<IndexedDBBlobInfo>());
 
     m_blob_info.push_back(
         IndexedDBBlobInfo("uuid 3", base::UTF8ToUTF16("blob type"), 1));
     m_blob_info.push_back(
@@ skipping 115 matching lines @@
 
  protected:
   virtual ~TestCallback() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TestCallback);
 };
 
 TEST_F(IndexedDBBackingStoreTest, PutGetConsistency) {
   {
-    IndexedDBBackingStore::Transaction transaction1(backing_store_);
+    IndexedDBBackingStore::Transaction transaction1(backing_store_.get());
     transaction1.Begin();
     ScopedVector<storage::BlobDataHandle> handles;
     IndexedDBBackingStore::RecordIdentifier record;
     leveldb::Status s = backing_store_->PutRecord(
         &transaction1, 1, 1, m_key1, &m_value1, &handles, &record);
     EXPECT_TRUE(s.ok());
     scoped_refptr<TestCallback> callback(new TestCallback());
     EXPECT_TRUE(transaction1.CommitPhaseOne(callback).ok());
     EXPECT_TRUE(callback->called);
     EXPECT_TRUE(callback->succeeded);
     EXPECT_TRUE(transaction1.CommitPhaseTwo().ok());
   }
 
   {
-    IndexedDBBackingStore::Transaction transaction2(backing_store_);
+    IndexedDBBackingStore::Transaction transaction2(backing_store_.get());
     transaction2.Begin();
     IndexedDBValue result_value;
     EXPECT_TRUE(
         backing_store_->GetRecord(&transaction2, 1, 1, m_key1, &result_value)
             .ok());
     scoped_refptr<TestCallback> callback(new TestCallback());
     EXPECT_TRUE(transaction2.CommitPhaseOne(callback).ok());
     EXPECT_TRUE(callback->called);
     EXPECT_TRUE(callback->succeeded);
     EXPECT_TRUE(transaction2.CommitPhaseTwo().ok());
     EXPECT_EQ(m_value1.bits, result_value.bits);
   }
 }
 
 TEST_F(IndexedDBBackingStoreTest, PutGetConsistencyWithBlobs) {
   {
-    IndexedDBBackingStore::Transaction transaction1(backing_store_);
+    IndexedDBBackingStore::Transaction transaction1(backing_store_.get());
     transaction1.Begin();
     ScopedVector<storage::BlobDataHandle> handles;
     IndexedDBBackingStore::RecordIdentifier record;
     EXPECT_TRUE(backing_store_->PutRecord(&transaction1,
                                           1,
                                           1,
                                           m_key3,
                                           &m_value3,
                                           &handles,
                                           &record).ok());
     scoped_refptr<TestCallback> callback(new TestCallback());
     EXPECT_TRUE(transaction1.CommitPhaseOne(callback).ok());
     task_runner_->RunUntilIdle();
     EXPECT_TRUE(CheckBlobWrites());
     EXPECT_TRUE(callback->called);
     EXPECT_TRUE(callback->succeeded);
     EXPECT_TRUE(transaction1.CommitPhaseTwo().ok());
   }
 
   {
-    IndexedDBBackingStore::Transaction transaction2(backing_store_);
+    IndexedDBBackingStore::Transaction transaction2(backing_store_.get());
     transaction2.Begin();
     IndexedDBValue result_value;
     EXPECT_TRUE(
         backing_store_->GetRecord(&transaction2, 1, 1, m_key3, &result_value)
             .ok());
     scoped_refptr<TestCallback> callback(new TestCallback());
     EXPECT_TRUE(transaction2.CommitPhaseOne(callback).ok());
     EXPECT_TRUE(callback->called);
     EXPECT_TRUE(callback->succeeded);
     EXPECT_TRUE(transaction2.CommitPhaseTwo().ok());
     EXPECT_EQ(m_value3.bits, result_value.bits);
     EXPECT_TRUE(CheckBlobInfoMatches(result_value.blob_info));
     EXPECT_TRUE(CheckBlobReadsMatchWrites(result_value.blob_info));
   }
 
   {
-    IndexedDBBackingStore::Transaction transaction3(backing_store_);
+    IndexedDBBackingStore::Transaction transaction3(backing_store_.get());
     transaction3.Begin();
     IndexedDBValue result_value;
     EXPECT_TRUE(backing_store_->DeleteRange(&transaction3,
                                             1,
                                             1,
                                             IndexedDBKeyRange(m_key3)).ok());
     scoped_refptr<TestCallback> callback(new TestCallback());
     EXPECT_TRUE(transaction3.CommitPhaseOne(callback).ok());
     task_runner_->RunUntilIdle();
     EXPECT_TRUE(callback->called);
@@ skipping 26 matching lines @@
       std::vector<IndexedDBBlobInfo> blob_info0, blob_info1, blob_info2,
           blob_info3;
       blob_info0.push_back(blob0);
       blob_info1.push_back(blob1);
       blob_info2.push_back(blob2);
       blob_info3.push_back(blob3);
       IndexedDBValue value0 = IndexedDBValue("value0", blob_info0);
       IndexedDBValue value1 = IndexedDBValue("value1", blob_info1);
       IndexedDBValue value2 = IndexedDBValue("value2", blob_info2);
       IndexedDBValue value3 = IndexedDBValue("value3", blob_info3);
-      IndexedDBBackingStore::Transaction transaction1(backing_store_);
+      IndexedDBBackingStore::Transaction transaction1(backing_store_.get());
       transaction1.Begin();
       ScopedVector<storage::BlobDataHandle> handles;
       IndexedDBBackingStore::RecordIdentifier record;
       EXPECT_TRUE(backing_store_->PutRecord(&transaction1,
                                             1,
                                             i + 1,
                                             key0,
                                             &value0,
                                             &handles,
                                             &record).ok());
@@ skipping 20 matching lines @@
                                             &record).ok());
       scoped_refptr<TestCallback> callback(new TestCallback());
       EXPECT_TRUE(transaction1.CommitPhaseOne(callback).ok());
       task_runner_->RunUntilIdle();
       EXPECT_TRUE(callback->called);
       EXPECT_TRUE(callback->succeeded);
       EXPECT_TRUE(transaction1.CommitPhaseTwo().ok());
     }
 
     {
-      IndexedDBBackingStore::Transaction transaction2(backing_store_);
+      IndexedDBBackingStore::Transaction transaction2(backing_store_.get());
       transaction2.Begin();
       IndexedDBValue result_value;
       EXPECT_TRUE(
           backing_store_->DeleteRange(&transaction2, 1, i + 1, ranges[i]).ok());
       scoped_refptr<TestCallback> callback(new TestCallback());
       EXPECT_TRUE(transaction2.CommitPhaseOne(callback).ok());
       task_runner_->RunUntilIdle();
       EXPECT_TRUE(callback->called);
       EXPECT_TRUE(callback->succeeded);
       EXPECT_TRUE(transaction2.CommitPhaseTwo().ok());
@@ skipping 28 matching lines @@
       std::vector<IndexedDBBlobInfo> blob_info0, blob_info1, blob_info2,
           blob_info3;
       blob_info0.push_back(blob0);
       blob_info1.push_back(blob1);
       blob_info2.push_back(blob2);
       blob_info3.push_back(blob3);
       IndexedDBValue value0 = IndexedDBValue("value0", blob_info0);
       IndexedDBValue value1 = IndexedDBValue("value1", blob_info1);
       IndexedDBValue value2 = IndexedDBValue("value2", blob_info2);
       IndexedDBValue value3 = IndexedDBValue("value3", blob_info3);
-      IndexedDBBackingStore::Transaction transaction1(backing_store_);
+      IndexedDBBackingStore::Transaction transaction1(backing_store_.get());
       transaction1.Begin();
       ScopedVector<storage::BlobDataHandle> handles;
       IndexedDBBackingStore::RecordIdentifier record;
       EXPECT_TRUE(backing_store_->PutRecord(&transaction1,
                                             1,
                                             i + 1,
                                             key0,
                                             &value0,
                                             &handles,
                                             &record).ok());
@@ skipping 20 matching lines @@
                                             &record).ok());
       scoped_refptr<TestCallback> callback(new TestCallback());
       EXPECT_TRUE(transaction1.CommitPhaseOne(callback).ok());
       task_runner_->RunUntilIdle();
       EXPECT_TRUE(callback->called);
       EXPECT_TRUE(callback->succeeded);
       EXPECT_TRUE(transaction1.CommitPhaseTwo().ok());
     }
 
     {
-      IndexedDBBackingStore::Transaction transaction2(backing_store_);
+      IndexedDBBackingStore::Transaction transaction2(backing_store_.get());
       transaction2.Begin();
       IndexedDBValue result_value;
       EXPECT_TRUE(
           backing_store_->DeleteRange(&transaction2, 1, i + 1, ranges[i]).ok());
       scoped_refptr<TestCallback> callback(new TestCallback());
       EXPECT_TRUE(transaction2.CommitPhaseOne(callback).ok());
       task_runner_->RunUntilIdle();
       EXPECT_TRUE(callback->called);
       EXPECT_TRUE(callback->succeeded);
       EXPECT_TRUE(transaction2.CommitPhaseTwo().ok());
       EXPECT_EQ(0UL, backing_store_->removals().size());
     }
   }
 }
 
 TEST_F(IndexedDBBackingStoreTest, LiveBlobJournal) {
   {
-    IndexedDBBackingStore::Transaction transaction1(backing_store_);
+    IndexedDBBackingStore::Transaction transaction1(backing_store_.get());
     transaction1.Begin();
     ScopedVector<storage::BlobDataHandle> handles;
     IndexedDBBackingStore::RecordIdentifier record;
     EXPECT_TRUE(backing_store_->PutRecord(&transaction1,
                                           1,
                                           1,
                                           m_key3,
                                           &m_value3,
                                           &handles,
                                           &record).ok());
     scoped_refptr<TestCallback> callback(new TestCallback());
     EXPECT_TRUE(transaction1.CommitPhaseOne(callback).ok());
     task_runner_->RunUntilIdle();
     EXPECT_TRUE(CheckBlobWrites());
     EXPECT_TRUE(callback->called);
     EXPECT_TRUE(callback->succeeded);
     EXPECT_TRUE(transaction1.CommitPhaseTwo().ok());
   }
 
   IndexedDBValue read_result_value;
   {
-    IndexedDBBackingStore::Transaction transaction2(backing_store_);
+    IndexedDBBackingStore::Transaction transaction2(backing_store_.get());
     transaction2.Begin();
     EXPECT_TRUE(
         backing_store_->GetRecord(
                             &transaction2, 1, 1, m_key3, &read_result_value)
             .ok());
     scoped_refptr<TestCallback> callback(new TestCallback());
     EXPECT_TRUE(transaction2.CommitPhaseOne(callback).ok());
     EXPECT_TRUE(callback->called);
     EXPECT_TRUE(callback->succeeded);
     EXPECT_TRUE(transaction2.CommitPhaseTwo().ok());
     EXPECT_EQ(m_value3.bits, read_result_value.bits);
     EXPECT_TRUE(CheckBlobInfoMatches(read_result_value.blob_info));
     EXPECT_TRUE(CheckBlobReadsMatchWrites(read_result_value.blob_info));
     for (size_t i = 0; i < read_result_value.blob_info.size(); ++i) {
       read_result_value.blob_info[i].mark_used_callback().Run();
     }
   }
 
   {
-    IndexedDBBackingStore::Transaction transaction3(backing_store_);
+    IndexedDBBackingStore::Transaction transaction3(backing_store_.get());
     transaction3.Begin();
     EXPECT_TRUE(backing_store_->DeleteRange(&transaction3,
                                             1,
                                             1,
                                             IndexedDBKeyRange(m_key3)).ok());
     scoped_refptr<TestCallback> callback(new TestCallback());
     EXPECT_TRUE(transaction3.CommitPhaseOne(callback).ok());
     task_runner_->RunUntilIdle();
     EXPECT_TRUE(callback->called);
     EXPECT_TRUE(callback->succeeded);
@@ skipping 16 matching lines @@
   const int64 high_object_store_id = 1ULL << 39;
   // index_ids are capped at 32 bits for storage purposes.
   const int64 high_index_id = 1ULL << 29;
 
   const int64 invalid_high_index_id = 1ULL << 37;
 
   const IndexedDBKey& index_key = m_key2;
   std::string index_key_raw;
   EncodeIDBKey(index_key, &index_key_raw);
   {
-    IndexedDBBackingStore::Transaction transaction1(backing_store_);
+    IndexedDBBackingStore::Transaction transaction1(backing_store_.get());
     transaction1.Begin();
     ScopedVector<storage::BlobDataHandle> handles;
     IndexedDBBackingStore::RecordIdentifier record;
     leveldb::Status s = backing_store_->PutRecord(&transaction1,
                                                   high_database_id,
                                                   high_object_store_id,
                                                   m_key1,
                                                   &m_value1,
                                                   &handles,
                                                   &record);
@@ skipping 18 matching lines @@
     scoped_refptr<TestCallback> callback(new TestCallback());
     s = transaction1.CommitPhaseOne(callback);
     EXPECT_TRUE(s.ok());
     EXPECT_TRUE(callback->called);
     EXPECT_TRUE(callback->succeeded);
     s = transaction1.CommitPhaseTwo();
     EXPECT_TRUE(s.ok());
   }
 
   {
-    IndexedDBBackingStore::Transaction transaction2(backing_store_);
+    IndexedDBBackingStore::Transaction transaction2(backing_store_.get());
     transaction2.Begin();
     IndexedDBValue result_value;
     leveldb::Status s = backing_store_->GetRecord(&transaction2,
                                                   high_database_id,
                                                   high_object_store_id,
                                                   m_key1,
                                                   &result_value);
     EXPECT_TRUE(s.ok());
     EXPECT_EQ(m_value1.bits, result_value.bits);
 
@@ skipping 28 matching lines @@
 // Make sure that other invalid ids do not crash.
 TEST_F(IndexedDBBackingStoreTest, InvalidIds) {
   // valid ids for use when testing invalid ids
   const int64 database_id = 1;
   const int64 object_store_id = 1;
   const int64 index_id = kMinimumIndexId;
   const int64 invalid_low_index_id = 19;  // index_ids must be > kMinimumIndexId
 
   IndexedDBValue result_value;
 
-  IndexedDBBackingStore::Transaction transaction1(backing_store_);
+  IndexedDBBackingStore::Transaction transaction1(backing_store_.get());
   transaction1.Begin();
 
   ScopedVector<storage::BlobDataHandle> handles;
   IndexedDBBackingStore::RecordIdentifier record;
   leveldb::Status s = backing_store_->PutRecord(&transaction1,
                                                 database_id,
                                                 KeyPrefix::kInvalidId,
                                                 m_key1,
                                                 &m_value1,
                                                 &handles,
@@ skipping 82 matching lines @@
   const bool unique = true;
   const bool multi_entry = true;
   const IndexedDBKeyPath index_key_path(ASCIIToUTF16("index_key"));
 
   {
     leveldb::Status s = backing_store_->CreateIDBDatabaseMetaData(
         database_name, version, int_version, &database_id);
     EXPECT_TRUE(s.ok());
     EXPECT_GT(database_id, 0);
 
-    IndexedDBBackingStore::Transaction transaction(backing_store_);
+    IndexedDBBackingStore::Transaction transaction(backing_store_.get());
     transaction.Begin();
 
     s = backing_store_->CreateObjectStore(&transaction,
                                           database_id,
                                           object_store_id,
                                           object_store_name,
                                           object_store_key_path,
                                           auto_increment);
     EXPECT_TRUE(s.ok());
 
@@ skipping 73 matching lines @@
 
   std::vector<base::string16> names = backing_store_->GetDatabaseNames(&s);
   EXPECT_TRUE(s.ok());
   EXPECT_EQ(names.size(), 1ULL);
   EXPECT_EQ(names[0], db1_name);
 }
 
 }  // namespace
 
 }  // namespace content