Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 501183002: Cleanup: remove HomeCardLayoutManager::Delegate. (Closed)

Created:
6 years, 4 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: remove HomeCardLayoutManager::Delegate. This class is simply unnecessary. BUG=None R=oshima@chromium.org TEST=athena_unittests passes Committed: https://crrev.com/9186bf10f8838577af77755ff51f5eaaec75385f Cr-Commit-Position: refs/heads/master@{#291841}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -31 lines) Patch
M athena/home/home_card_impl.cc View 1 7 chunks +19 lines, -31 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Jun Mukai
6 years, 4 months ago (2014-08-25 21:34:14 UTC) #1
oshima
lgtm
6 years, 4 months ago (2014-08-25 21:55:18 UTC) #2
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 4 months ago (2014-08-25 21:56:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/501183002/1
6 years, 4 months ago (2014-08-25 21:58:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-25 23:30:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 23:32:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/46075) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/9239) chromium_presubmit ...
6 years, 4 months ago (2014-08-25 23:32:37 UTC) #7
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 4 months ago (2014-08-26 01:18:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/501183002/20001
6 years, 4 months ago (2014-08-26 01:19:29 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (20001) as 627f5cdd9e71f901f79c6cad1d51ffd91a7cd4d3
6 years, 4 months ago (2014-08-26 04:41:35 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:40:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9186bf10f8838577af77755ff51f5eaaec75385f
Cr-Commit-Position: refs/heads/master@{#291841}

Powered by Google App Engine
This is Rietveld 408576698