Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 501173002: Generate symbols in debug GN builds. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/7927079955d2767e1fa812fe58432fcb9d6250aa Cr-Commit-Position: refs/heads/master@{#291803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -35 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +1 line, -7 lines 0 comments Download
M build/config/compiler/BUILD.gn View 4 chunks +50 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 4 months ago (2014-08-25 20:14:15 UTC) #1
scottmg
lgtm
6 years, 4 months ago (2014-08-25 20:15:21 UTC) #2
brettw
Committed patchset #1 to pending queue manually as 187bbec (presubmit successful).
6 years, 4 months ago (2014-08-26 00:25:27 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:39:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7927079955d2767e1fa812fe58432fcb9d6250aa
Cr-Commit-Position: refs/heads/master@{#291803}

Powered by Google App Engine
This is Rietveld 408576698