Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: net/url_request/url_request_job_factory_impl_unittest.cc

Issue 501163002: Make URLRequest's constructor private, and make URLRequestContext a friend class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge yet again Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_http_job_unittest.cc ('k') | net/url_request/url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_job_factory_impl_unittest.cc
diff --git a/net/url_request/url_request_job_factory_impl_unittest.cc b/net/url_request/url_request_job_factory_impl_unittest.cc
index 93ca0f83f3727b94f20a49353824b1bc344aba50..2c36976b48c321701705f1d8e8c2d8a0dcee10cd 100644
--- a/net/url_request/url_request_job_factory_impl_unittest.cc
+++ b/net/url_request/url_request_job_factory_impl_unittest.cc
@@ -5,6 +5,7 @@
#include "net/url_request/url_request_job_factory_impl.h"
#include "base/bind.h"
+#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "net/base/request_priority.h"
#include "net/url_request/url_request.h"
@@ -60,13 +61,13 @@ class DummyProtocolHandler : public URLRequestJobFactory::ProtocolHandler {
TEST(URLRequestJobFactoryTest, NoProtocolHandler) {
TestDelegate delegate;
TestURLRequestContext request_context;
- TestURLRequest request(
- GURL("foo://bar"), DEFAULT_PRIORITY, &delegate, &request_context);
- request.Start();
+ scoped_ptr<URLRequest> request(request_context.CreateRequest(
+ GURL("foo://bar"), DEFAULT_PRIORITY, &delegate, NULL));
+ request->Start();
base::MessageLoop::current()->Run();
- EXPECT_EQ(URLRequestStatus::FAILED, request.status().status());
- EXPECT_EQ(ERR_UNKNOWN_URL_SCHEME, request.status().error());
+ EXPECT_EQ(URLRequestStatus::FAILED, request->status().status());
+ EXPECT_EQ(ERR_UNKNOWN_URL_SCHEME, request->status().error());
}
TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {
@@ -75,13 +76,13 @@ TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {
TestURLRequestContext request_context;
request_context.set_job_factory(&job_factory);
job_factory.SetProtocolHandler("foo", new DummyProtocolHandler);
- TestURLRequest request(
- GURL("foo://bar"), DEFAULT_PRIORITY, &delegate, &request_context);
- request.Start();
+ scoped_ptr<URLRequest> request(request_context.CreateRequest(
+ GURL("foo://bar"), DEFAULT_PRIORITY, &delegate, NULL));
+ request->Start();
base::MessageLoop::current()->Run();
- EXPECT_EQ(URLRequestStatus::SUCCESS, request.status().status());
- EXPECT_EQ(OK, request.status().error());
+ EXPECT_EQ(URLRequestStatus::SUCCESS, request->status().status());
+ EXPECT_EQ(OK, request->status().error());
}
TEST(URLRequestJobFactoryTest, DeleteProtocolHandler) {
« no previous file with comments | « net/url_request/url_request_http_job_unittest.cc ('k') | net/url_request/url_request_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698