Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc

Issue 501163002: Make URLRequest's constructor private, and make URLRequestContext a friend class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge? Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
index fbb7aa69a76b698d437c8ab2d247603236526a67..9e1dcf6c0d61997c68a0b2acdf63f9a6d9a06ab0 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc
@@ -25,6 +25,7 @@
#include "extensions/common/extension.h"
#include "net/base/request_priority.h"
#include "net/http/http_response_headers.h"
+#include "net/url_request/url_request.h"
#include "net/url_request/url_request_test_util.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -140,12 +141,12 @@ bool WebRequestActionWithThreadsTest::ActionWorksOnRequest(
const std::string& extension_id,
const WebRequestActionSet* action_set,
RequestStage stage) {
- net::TestURLRequest regular_request(
- GURL(url_string), net::DEFAULT_PRIORITY, NULL, &context_);
+ scoped_ptr<net::URLRequest> regular_request(context_.CreateRequest(
+ GURL(url_string), net::DEFAULT_PRIORITY, NULL, NULL));
std::list<LinkedPtrEventResponseDelta> deltas;
scoped_refptr<net::HttpResponseHeaders> headers(
new net::HttpResponseHeaders(""));
- WebRequestData request_data(&regular_request, stage, headers.get());
+ WebRequestData request_data(regular_request.get(), stage, headers.get());
std::set<std::string> ignored_tags;
WebRequestAction::ApplyInfo apply_info = { extension_info_map_.get(),
request_data,

Powered by Google App Engine
This is Rietveld 408576698