Make URLRequest's constructor private, and make URLRequestContext a friend class.

chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.h"
 
 #include <set>
 
+#include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/test/values_test_util.h"
 #include "base/values.h"
 #include "components/url_matcher/url_matcher_constants.h"
 #include "content/public/browser/resource_request_info.h"
 #include "extensions/browser/api/declarative_webrequest/webrequest_constants.h"
 #include "net/base/request_priority.h"
+#include "net/url_request/url_request.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::ResourceType;
 using url_matcher::URLMatcher;
 using url_matcher::URLMatcherConditionSet;
 
 namespace extensions {
 
 TEST(WebRequestConditionTest, CreateCondition) {
@@ skipping 45 matching lines @@
       &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(result.get());
 
   URLMatcherConditionSet::Vector url_matcher_condition_set;
   result->GetURLMatcherConditionSets(&url_matcher_condition_set);
   matcher.AddConditionSets(url_matcher_condition_set);
 
   net::TestURLRequestContext context;
   const GURL http_url("http://www.example.com");
-  net::TestURLRequest match_request(
-      http_url, net::DEFAULT_PRIORITY, NULL, &context);
-  WebRequestData data(&match_request, ON_BEFORE_REQUEST);
+  scoped_ptr<net::URLRequest> match_request(context.CreateRequest(
+      http_url, net::DEFAULT_PRIORITY, NULL, NULL));
+  WebRequestData data(match_request.get(), ON_BEFORE_REQUEST);
   WebRequestDataWithMatchIds request_data(&data);
   request_data.url_match_ids = matcher.MatchURL(http_url);
   EXPECT_EQ(1u, request_data.url_match_ids.size());
   content::ResourceRequestInfo::AllocateForTesting(
-      &match_request,
+      match_request.get(),
       content::RESOURCE_TYPE_MAIN_FRAME,
       NULL,
       -1,
       -1,
       -1,
       false);
   EXPECT_TRUE(result->IsFulfilled(request_data));
 
   const GURL https_url("https://www.example.com");
-  net::TestURLRequest wrong_resource_type(
-      https_url, net::DEFAULT_PRIORITY, NULL, &context);
-  data.request = &wrong_resource_type;
+  scoped_ptr<net::URLRequest> wrong_resource_type(context.CreateRequest(
+      https_url, net::DEFAULT_PRIORITY, NULL, NULL));
+  data.request = wrong_resource_type.get();
   request_data.url_match_ids = matcher.MatchURL(http_url);
   // Make sure IsFulfilled does not fail because of URL matching.
   EXPECT_EQ(1u, request_data.url_match_ids.size());
   content::ResourceRequestInfo::AllocateForTesting(
-      &wrong_resource_type,
+      wrong_resource_type.get(),
       content::RESOURCE_TYPE_SUB_FRAME,
       NULL,
       -1,
       -1,
       -1,
       false);
   EXPECT_FALSE(result->IsFulfilled(request_data));
 }
 
 TEST(WebRequestConditionTest, CreateConditionFirstPartyForCookies) {
@@ skipping 16 matching lines @@
   EXPECT_EQ("", error);
   ASSERT_TRUE(result.get());
 
   URLMatcherConditionSet::Vector url_matcher_condition_set;
   result->GetURLMatcherConditionSets(&url_matcher_condition_set);
   matcher.AddConditionSets(url_matcher_condition_set);
 
   net::TestURLRequestContext context;
   const GURL http_url("http://www.example.com");
   const GURL first_party_url("http://fpfc.example.com");
-  net::TestURLRequest match_request(
-      http_url, net::DEFAULT_PRIORITY, NULL, &context);
-  WebRequestData data(&match_request, ON_BEFORE_REQUEST);
+  scoped_ptr<net::URLRequest> match_request(context.CreateRequest(
+      http_url, net::DEFAULT_PRIORITY, NULL, NULL));
+  WebRequestData data(match_request.get(), ON_BEFORE_REQUEST);
   WebRequestDataWithMatchIds request_data(&data);
   request_data.url_match_ids = matcher.MatchURL(http_url);
   EXPECT_EQ(0u, request_data.url_match_ids.size());
   request_data.first_party_url_match_ids = matcher.MatchURL(first_party_url);
   EXPECT_EQ(1u, request_data.first_party_url_match_ids.size());
   content::ResourceRequestInfo::AllocateForTesting(
-      &match_request,
+      match_request.get(),
       content::RESOURCE_TYPE_MAIN_FRAME,
       NULL,
       -1,
       -1,
       -1,
       false);
   EXPECT_TRUE(result->IsFulfilled(request_data));
 }
 
 // Conditions without UrlFilter attributes need to be independent of URL
@@ skipping 49 matching lines @@
                "{ \n"
                "  \"instanceType\": \"declarativeWebRequest.RequestMatcher\", "
                "\n"
                "  \"thirdPartyForCookies\": true, \n"
                "}"),
           &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(condition_no_url_false.get());
 
   net::TestURLRequestContext context;
-  net::TestURLRequest https_request(
-      GURL("https://www.example.com"), net::DEFAULT_PRIORITY, NULL, &context);
+  scoped_ptr<net::URLRequest> https_request(context.CreateRequest(
+      GURL("https://www.example.com"), net::DEFAULT_PRIORITY, NULL, NULL));
 
   // 1. A non-empty condition without UrlFilter attributes is fulfilled iff its
   //    attributes are fulfilled.
-  WebRequestData data(&https_request, ON_BEFORE_REQUEST);
+  WebRequestData data(https_request.get(), ON_BEFORE_REQUEST);
   EXPECT_FALSE(
       condition_no_url_false->IsFulfilled(WebRequestDataWithMatchIds(&data)));
 
-  data = WebRequestData(&https_request, ON_BEFORE_REQUEST);
+  data = WebRequestData(https_request.get(), ON_BEFORE_REQUEST);
   EXPECT_TRUE(
       condition_no_url_true->IsFulfilled(WebRequestDataWithMatchIds(&data)));
 
   // 2. An empty condition (in particular, without UrlFilter attributes) is
   //    always fulfilled.
-  data = WebRequestData(&https_request, ON_BEFORE_REQUEST);
+  data = WebRequestData(https_request.get(), ON_BEFORE_REQUEST);
   EXPECT_TRUE(condition_empty->IsFulfilled(WebRequestDataWithMatchIds(&data)));
 }
 
 TEST(WebRequestConditionTest, CreateConditionSet) {
   // Necessary for TestURLRequest.
   base::MessageLoopForIO message_loop;
   URLMatcher matcher;
 
   WebRequestConditionSet::AnyVector conditions;
   conditions.push_back(linked_ptr<base::Value>(base::test::ParseJson(
@@ skipping 24 matching lines @@
 
   // Tell the URLMatcher about our shiny new patterns.
   URLMatcherConditionSet::Vector url_matcher_condition_set;
   result->GetURLMatcherConditionSets(&url_matcher_condition_set);
   matcher.AddConditionSets(url_matcher_condition_set);
 
   // Test that the result is correct and matches http://www.example.com and
   // https://www.example.com
   GURL http_url("http://www.example.com");
   net::TestURLRequestContext context;
-  net::TestURLRequest http_request(
-      http_url, net::DEFAULT_PRIORITY, NULL, &context);
-  WebRequestData data(&http_request, ON_BEFORE_REQUEST);
+  scoped_ptr<net::URLRequest> http_request(context.CreateRequest(
+      http_url, net::DEFAULT_PRIORITY, NULL, NULL));
+  WebRequestData data(http_request.get(), ON_BEFORE_REQUEST);
   WebRequestDataWithMatchIds request_data(&data);
   request_data.url_match_ids = matcher.MatchURL(http_url);
   EXPECT_EQ(1u, request_data.url_match_ids.size());
   EXPECT_TRUE(result->IsFulfilled(*(request_data.url_match_ids.begin()),
                                   request_data));
 
   GURL https_url("https://www.example.com");
   request_data.url_match_ids = matcher.MatchURL(https_url);
   EXPECT_EQ(1u, request_data.url_match_ids.size());
-  net::TestURLRequest https_request(
-      https_url, net::DEFAULT_PRIORITY, NULL, &context);
-  data.request = &https_request;
+  scoped_ptr<net::URLRequest> https_request(context.CreateRequest(
+      https_url, net::DEFAULT_PRIORITY, NULL, NULL));
+  data.request = https_request.get();
   EXPECT_TRUE(result->IsFulfilled(*(request_data.url_match_ids.begin()),
                                   request_data));
 
   // Check that both, hostPrefix and hostSuffix are evaluated.
   GURL https_foo_url("https://foo.example.com");
   request_data.url_match_ids = matcher.MatchURL(https_foo_url);
   EXPECT_EQ(0u, request_data.url_match_ids.size());
-  net::TestURLRequest https_foo_request(
-      https_foo_url, net::DEFAULT_PRIORITY, NULL, &context);
-  data.request = &https_foo_request;
+  scoped_ptr<net::URLRequest> https_foo_request(context.CreateRequest(
+      https_foo_url, net::DEFAULT_PRIORITY, NULL, NULL));
+  data.request = https_foo_request.get();
   EXPECT_FALSE(result->IsFulfilled(-1, request_data));
 }
 
 TEST(WebRequestConditionTest, TestPortFilter) {
   // Necessary for TestURLRequest.
   base::MessageLoopForIO message_loop;
   URLMatcher matcher;
 
   WebRequestConditionSet::AnyVector conditions;
   conditions.push_back(linked_ptr<base::Value>(base::test::ParseJson(
@@ skipping 16 matching lines @@
   // Tell the URLMatcher about our shiny new patterns.
   URLMatcherConditionSet::Vector url_matcher_condition_set;
   result->GetURLMatcherConditionSets(&url_matcher_condition_set);
   matcher.AddConditionSets(url_matcher_condition_set);
 
   std::set<URLMatcherConditionSet::ID> url_match_ids;
 
   // Test various URLs.
   GURL http_url("http://www.example.com");
   net::TestURLRequestContext context;
-  net::TestURLRequest http_request(
-      http_url, net::DEFAULT_PRIORITY, NULL, &context);
+  scoped_ptr<net::URLRequest> http_request(context.CreateRequest(
+      http_url, net::DEFAULT_PRIORITY, NULL, NULL));
   url_match_ids = matcher.MatchURL(http_url);
   ASSERT_EQ(1u, url_match_ids.size());
 
   GURL http_url_80("http://www.example.com:80");
-  net::TestURLRequest http_request_80(
-      http_url_80, net::DEFAULT_PRIORITY, NULL, &context);
+  scoped_ptr<net::URLRequest> http_request_80(context.CreateRequest(
+      http_url_80, net::DEFAULT_PRIORITY, NULL, NULL));
   url_match_ids = matcher.MatchURL(http_url_80);
   ASSERT_EQ(1u, url_match_ids.size());
 
   GURL http_url_1000("http://www.example.com:1000");
-  net::TestURLRequest http_request_1000(
-      http_url_1000, net::DEFAULT_PRIORITY, NULL, &context);
+  scoped_ptr<net::URLRequest> http_request_1000(context.CreateRequest(
+      http_url_1000, net::DEFAULT_PRIORITY, NULL, NULL));
   url_match_ids = matcher.MatchURL(http_url_1000);
   ASSERT_EQ(1u, url_match_ids.size());
 
   GURL http_url_2000("http://www.example.com:2000");
-  net::TestURLRequest http_request_2000(
-      http_url_2000, net::DEFAULT_PRIORITY, NULL, &context);
+  scoped_ptr<net::URLRequest> http_request_2000(context.CreateRequest(
+      http_url_2000, net::DEFAULT_PRIORITY, NULL, NULL));
   url_match_ids = matcher.MatchURL(http_url_2000);
   ASSERT_EQ(0u, url_match_ids.size());
 }
 
 // Create a condition with two attributes: one on the request header and one on
 // the response header. The Create() method should fail and complain that it is
 // impossible that both conditions are fulfilled at the same time.
 TEST(WebRequestConditionTest, ConditionsWithConflictingStages) {
   // Necessary for TestURLRequest.
   base::MessageLoopForIO message_loop;
@@ skipping 14 matching lines @@
            // filters.
            "  \"requestHeaders\": [{}], \n"
            "  \"responseHeaders\": [{}], \n"
            "}"),
       &error);
   EXPECT_FALSE(error.empty());
   EXPECT_FALSE(result.get());
 }
 
 }  // namespace extensions