Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 501153006: [DevTools] Implement Page.canEmulate capability. (Closed)

Created:
6 years, 3 months ago by dgozman
Modified:
6 years, 3 months ago
Reviewers:
vsevik, pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Implement Page.canEmulate capability. BUG=none Committed: https://crrev.com/a0f0a2625f50b7f7f52c0d03028be57b9982fdaa Cr-Commit-Position: refs/heads/master@{#292374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M content/browser/devtools/renderer_overrides_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler.cc View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dgozman
dgozman@chromium.org changed reviewers: + pfeldman@chromium.org, vsevik@chromium.org
6 years, 3 months ago (2014-08-28 08:58:32 UTC) #1
dgozman
Take a look please.
6 years, 3 months ago (2014-08-28 08:58:32 UTC) #2
vsevik
lgtm
6 years, 3 months ago (2014-08-28 12:37:20 UTC) #3
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 3 months ago (2014-08-28 12:45:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/501153006/1
6 years, 3 months ago (2014-08-28 12:46:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2e3770355380c560014877f93204c1fe44506b07
6 years, 3 months ago (2014-08-28 13:40:26 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:59:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0f0a2625f50b7f7f52c0d03028be57b9982fdaa
Cr-Commit-Position: refs/heads/master@{#292374}

Powered by Google App Engine
This is Rietveld 408576698