Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 501153005: uber: compile fixes + .gyp file to build. (Closed)

Created:
6 years, 4 months ago by Dan Beam
Modified:
6 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, vitalyp+closure_chromium.org, arv+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

uber: compile fixes + .gyp file to build. R=estade@chromium.org BUG=393873 Committed: https://crrev.com/a5c2c1ccb5621e2299c206d7fde9e3b8c2abde5d Cr-Commit-Position: refs/heads/master@{#291991}

Patch Set 1 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
A + chrome/browser/resources/uber/compiled_resources.gyp View 2 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/resources/uber/uber.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/uber/uber_utils.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/closure_compiler/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Dan Beam
Patchset #1 (id:1) has been deleted
6 years, 4 months ago (2014-08-26 04:59:24 UTC) #1
Dan Beam
6 years, 4 months ago (2014-08-26 05:00:08 UTC) #2
Evan Stade
lgtm
6 years, 3 months ago (2014-08-26 17:41:23 UTC) #3
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 3 months ago (2014-08-26 17:46:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/501153005/20001
6 years, 3 months ago (2014-08-26 17:48:10 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-26 19:00:04 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 19:19:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/44346)
6 years, 3 months ago (2014-08-26 19:19:24 UTC) #8
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 3 months ago (2014-08-26 22:03:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/501153005/20001
6 years, 3 months ago (2014-08-26 22:04:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (20001) as 4873bc5f9f521ab2e0e1a00479017641a62980ff
6 years, 3 months ago (2014-08-26 22:07:20 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:45:56 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a5c2c1ccb5621e2299c206d7fde9e3b8c2abde5d
Cr-Commit-Position: refs/heads/master@{#291991}

Powered by Google App Engine
This is Rietveld 408576698