Unfurl catch-all bounds(). This makes it a little easier to track progress.

Unfurl catch-all bounds().  This makes it a little easier to track progress.

I think we've worked out the SaveLayer bounds as of crrev.com/496963003, so
remove that TODO.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/68199a2d5f0cd0b9577b9695b9e095e720e96950

[mtklein, 2014-08-25 19:52:57]

Pretty close to a no-op refactor.  The only real change here is completing the
set of control-ops that should inherit their bounds from their DrawSomething
peers.

[mtklein, 2014-08-25 19:52:59]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-25 19:53:16]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/501153002/1

[commit-bot: I haz the power, 2014-08-25 19:53:17]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-08-26 01:53 UTC

[robertphillips, 2014-08-25 20:28:07]

The CQ bit was unchecked by robertphillips@google.com

[robertphillips, 2014-08-25 20:28:19]

lgtm + a question

https://codereview.chromium.org/501153002/diff/1/src/core/SkRecordDraw.cpp
File src/core/SkRecordDraw.cpp (right):

https://codereview.chromium.org/501153002/diff/1/src/core/SkRecordDraw.cpp#ne...
src/core/SkRecordDraw.cpp:195: void trackBounds(const ClipRegion&)        {
this->pushControl(); }
Seems like we should do more with the culling information.

https://codereview.chromium.org/501153002/diff/1/src/core/SkRecordDraw.cpp#ne...
src/core/SkRecordDraw.cpp:197: void trackBounds(const PopCull&)           {
this->pushControl(); }
Could these guys be treated like Noop (since they don't draw) ?

[mtklein, 2014-08-25 20:36:13]

https://codereview.chromium.org/501153002/diff/1/src/core/SkRecordDraw.cpp
File src/core/SkRecordDraw.cpp (right):

https://codereview.chromium.org/501153002/diff/1/src/core/SkRecordDraw.cpp#ne...
src/core/SkRecordDraw.cpp:195: void trackBounds(const ClipRegion&)        {
this->pushControl(); }
On 2014/08/25 20:28:19, robertphillips wrote:
> Seems like we should do more with the culling information.

Yes.  It's a little moot right now because we're not getting these at the
moment.  But we could do the same sort of thing we do with save layer bounds,
clipping the bounds down further as we receive pushCulls (and newly, undoing
that when we hit a popCull()).

https://codereview.chromium.org/501153002/diff/1/src/core/SkRecordDraw.cpp#ne...
src/core/SkRecordDraw.cpp:197: void trackBounds(const PopCull&)           {
this->pushControl(); }
On 2014/08/25 20:28:19, robertphillips wrote:
> Could these guys be treated like Noop (since they don't draw) ?

Could be, but then we'd be in the odd spot of playing back something different
than was recorded.  NoOps aren't ever recorded, so we can do whatever we like
with them, but it'd really be a bad idea for us to swallow culls if the target
canvas was looking for them.

[mtklein, 2014-08-25 20:48:21]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-25 20:49:26]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/501153002/1

[commit-bot: I haz the power, 2014-08-25 20:49:35]

Committed patchset #1 (1) as 68199a2d5f0cd0b9577b9695b9e095e720e96950