Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 501143003: Switch some fields in omnibox.mojom to non-nullable. (Closed)

Created:
6 years, 4 months ago by yzshen1
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), James Su, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switch some fields in omnibox.mojom to non-nullable. BUG=406580 TEST=None Committed: https://crrev.com/d6027822f22677618c746c6af92cdb4e26b22c3e Cr-Commit-Position: refs/heads/master@{#291777}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M chrome/browser/ui/webui/omnibox/omnibox.mojom View 3 chunks +19 lines, -16 lines 1 comment Download

Messages

Total messages: 11 (0 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks! https://codereview.chromium.org/501143003/diff/1/chrome/browser/ui/webui/omnibox/omnibox.mojom File chrome/browser/ui/webui/omnibox/omnibox.mojom (right): https://codereview.chromium.org/501143003/diff/1/chrome/browser/ui/webui/omnibox/omnibox.mojom#newcode52 chrome/browser/ui/webui/omnibox/omnibox.mojom:52: ...
6 years, 4 months ago (2014-08-25 20:25:33 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-25 20:48:26 UTC) #2
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-25 20:49:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/501143003/1
6 years, 4 months ago (2014-08-25 20:51:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-25 21:59:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 22:34:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/5919)
6 years, 4 months ago (2014-08-25 22:34:51 UTC) #7
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-25 22:40:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/501143003/1
6 years, 4 months ago (2014-08-25 22:43:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (1) as 6e7be00af52049c3945862c0fec30d12c49c6521
6 years, 4 months ago (2014-08-25 23:01:54 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:38:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6027822f22677618c746c6af92cdb4e26b22c3e
Cr-Commit-Position: refs/heads/master@{#291777}

Powered by Google App Engine
This is Rietveld 408576698