Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 501135: Revert 34998, more stabbing in the dark to find a perf regression - Mac: impl... (Closed)

Created:
11 years ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Revert 34998, more stabbing in the dark to find a perf regression - Mac: implement DnD of URLs onto Omnibox. (DnD of text coming in another patch.) BUG=24631 TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location. Review URL: http://codereview.chromium.org/481012 TBR=viettrungluu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -179 lines) Patch
M chrome/browser/cocoa/autocomplete_text_field.h View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/cocoa/autocomplete_text_field.mm View 3 chunks +0 lines, -36 lines 0 comments Download
M chrome/browser/cocoa/autocomplete_text_field_editor.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/browser_window_controller.h View 4 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/cocoa/browser_window_controller.mm View 4 chunks +20 lines, -5 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller.h View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller.mm View 8 chunks +19 lines, -25 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/tab_strip_view.mm View 2 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/cocoa/toolbar_controller.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/toolbar_controller.mm View 2 chunks +0 lines, -35 lines 0 comments Download
M chrome/browser/cocoa/url_drop_target.h View 2 chunks +15 lines, -36 lines 0 comments Download
M chrome/browser/cocoa/url_drop_target.mm View 4 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
11 years ago (2009-12-19 03:30:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698