Issue 501103: Mac: correctly fix Omnibox drawing (again), and make the focus ring come back.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 501103: Mac: correctly fix Omnibox drawing (again), and make the focus ring come back. (Closed)

Created:
11 years ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Mac: correctly fix Omnibox drawing (again), and make the focus ring come back. (Somehow I managed to miss the drawing code I should have modified before.) BUG=30188, 30716 TEST=Make sure Omnibox border draws correctly (zoom in closely and look) and matches the buttons; do so with a wide variety of themes. Make sure the blue focus ring appears when appropriate. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34952

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -55 lines)			Patch
	M	chrome/browser/cocoa/autocomplete_text_field_cell.mm	View		1 chunk	+0 lines, -42 lines	0 comments	Download
	M	chrome/browser/cocoa/styled_text_field_cell.mm	View		1 chunk	+29 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages