Issue 501099: Http cache: Add a test to make sure that the cache...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 501099: Http cache: Add a test to make sure that the cache... (Closed)

Created:
11 years ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Http cache: Add a test to make sure that the cache works as expected with synchronous responses. As an added bonus, now changing the default test mode of kRangeGET_TransactionOK doesn't end up with some tests hanging, so it is easy to manually verify that all tests work as expected. BUG=26729 TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34914

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -45 lines)			Patch
M	net/base/test_completion_callback.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	net/disk_cache/backend_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	net/disk_cache/disk_cache_test_util.h	View		2 chunks	+0 lines, -19 lines	0 comments	Download
M	net/disk_cache/disk_cache_test_util.cc	View		2 chunks	+0 lines, -9 lines	0 comments	Download
M	net/disk_cache/entry_unittest.cc	View		4 chunks	+6 lines, -5 lines	0 comments	Download
M	net/http/http_cache_transaction.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_cache_unittest.cc	View	1	4 chunks	+64 lines, -10 lines	0 comments	Download
M	net/http/http_transaction_unittest.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eroman

11 years ago (2009-12-18 00:18:38 UTC) #2

LGTM!

http://codereview.chromium.org/501099/diff/1/4
File net/http/http_transaction_unittest.h (right):

http://codereview.chromium.org/501099/diff/1/4#newcode37
net/http/http_transaction_unittest.h:37: TEST_MODE_ALL_SYNC = 0x1F
I think this would be clearer as an OR of the above flags.
(My first reaction was to wander what 0x1F was)

Expand Messages | Collapse Messages