Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 501093007: [aw] Fix crash when "misbehave" app exits fullscreen. (Closed)

Created:
6 years, 3 months ago by Ignacio Solla
Modified:
6 years, 3 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[aw] Fix crash when "misbehave" app exits fullscreen. exitFullScreen() might be call without a prior call to enterFullScreen() if a "misbehave" app overrides onShowCustomView but does not add the custom view to the window. This fixes a crash by returning early from exitFullScreen in that case. BUG=408133 Committed: https://crrev.com/c0e9f01149baa440a7e4f19ba2705f17017a7b43 Cr-Commit-Position: refs/heads/master@{#292165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ignacio Solla
igsolla@chromium.org changed reviewers: + benm@chromium.org
6 years, 3 months ago (2014-08-27 15:22:38 UTC) #1
Ignacio Solla
6 years, 3 months ago (2014-08-27 15:22:38 UTC) #2
benm (inactive)
lgtm; however will need a crbug + merge request to M38 please.
6 years, 3 months ago (2014-08-27 15:30:02 UTC) #3
Ignacio Solla
The CQ bit was checked by igsolla@chromium.org
6 years, 3 months ago (2014-08-27 15:33:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igsolla@chromium.org/501093007/1
6 years, 3 months ago (2014-08-27 15:35:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6fde5e90aacdd861d913cb73b1002c0f98ebd575
6 years, 3 months ago (2014-08-27 16:21:25 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:52:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0e9f01149baa440a7e4f19ba2705f17017a7b43
Cr-Commit-Position: refs/heads/master@{#292165}

Powered by Google App Engine
This is Rietveld 408576698