Consolidate AppControllDelegate to ExtensionsDelegate

athena/extensions/shell/extensions_delegate_impl.cc

Index: athena/extensions/shell/extensions_delegate_impl.cc
diff --git a/athena/extensions/shell/extensions_delegate_impl.cc b/athena/extensions/shell/extensions_delegate_impl.cc
index da3566cca15e2a45bf42caa7bd689cdee600b123..13161779e3f67852a7310498ea2d4471ddde70ad 100644
--- a/athena/extensions/shell/extensions_delegate_impl.cc
+++ b/athena/extensions/shell/extensions_delegate_impl.cc
@@ -30,10 +30,13 @@ class ShellExtensionsDelegate : public ExtensionsDelegate {
       shell_extensions_.Insert(extension_system_->extension());
     return shell_extensions_;
   }
-  virtual void LaunchApp(const std::string& app_id) OVERRIDE {
+  virtual bool LaunchApp(const std::string& app_id) OVERRIDE {
     extension_system_->LaunchApp();
+    return true;
   }
 
+  virtual bool UnloadApp(const std::string& app_id) OVERRIDE { return false; }

[Mr4D (OOO till 08-26), 2014/08/27 20:22:19]

Add a todo here that this should be implemented using the extension system since
returning false will close the app window by window which will guarantee that
the windows will not be re-opened upon reload (and the background page might
remain open as well).

[oshima, 2014/08/27 21:20:19]

There will be chrome version
(athena/extensions/shell/extensions_delegate_impl.cc), where you have to add
impl. I'll add TODO there.

[Mr4D (OOO till 08-26), 2014/08/27 22:07:11]

You've forgot the TODO.

[oshima, 2014/08/27 22:19:20]

Discussed offline and we both agreed that we don't need TODO here.
(It'll be in athena/extensions/chrome/extensions_delegate_impl.cc)

+
   content::BrowserContext* context_;
   extensions::ShellExtensionSystem* extension_system_;
   extensions::ExtensionSet shell_extensions_;