Surface battery auditing information on the website settings option page.

Surface battery auditing information on the website settings option page.

BUG=372607
Committed: https://crrev.com/eda5899ef0421aa552c7b76eb87bb195b4fb1822
Cr-Commit-Position: refs/heads/master@{#292190}

[Daniel Nishi, 2014-08-25 17:17:01]

bauerb: PTAL.

[Daniel Nishi, 2014-08-25 18:29:20]

Patchset #1 (id:40001) has been deleted

[Bernhard Bauer, 2014-08-26 08:16:08]

https://codereview.chromium.org/501063002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/website_settings_edit_page.js (right):

https://codereview.chromium.org/501063002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/website_settings_edit_page.js:108: permissions,
showPage) {
Indent two more spaces. Alternatively, break after function.

https://codereview.chromium.org/501063002/diff/60001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/website_settings_handler.cc (right):

https://codereview.chromium.org/501063002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/website_settings_handler.cc:376:
origin_entry->SetWithoutPathExpansion(
The ...WithoutPathExpansion variant isn't necessary if you know that the key
doesn't contain periods. And there's SetInt to directly set an integer.

https://codereview.chromium.org/501063002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/website_settings_handler.cc:378:
origin_entry->SetWithoutPathExpansion(
SetString() here.

https://codereview.chromium.org/501063002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/website_settings_handler.cc:416:
Profile::FromWebUI(web_ui()))->GetPowerForOrigin(site_url);
Indent just four spaces w/r/t the preceding line.

[Daniel Nishi, 2014-08-26 17:45:05]

Patchset #2 (id:80001) has been deleted

[Daniel Nishi, 2014-08-26 17:45:39]

https://codereview.chromium.org/501063002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/options/website_settings_edit_page.js (right):

https://codereview.chromium.org/501063002/diff/60001/chrome/browser/resources...
chrome/browser/resources/options/website_settings_edit_page.js:108: permissions,
showPage) {
On 2014/08/26 08:16:07, Bernhard Bauer wrote:
> Indent two more spaces. Alternatively, break after function.

Indent added.

https://codereview.chromium.org/501063002/diff/60001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/website_settings_handler.cc (right):

https://codereview.chromium.org/501063002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/website_settings_handler.cc:376:
origin_entry->SetWithoutPathExpansion(
On 2014/08/26 08:16:07, Bernhard Bauer wrote:
> The ...WithoutPathExpansion variant isn't necessary if you know that the key
> doesn't contain periods. And there's SetInt to directly set an integer.

Done.

https://codereview.chromium.org/501063002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/website_settings_handler.cc:378:
origin_entry->SetWithoutPathExpansion(
On 2014/08/26 08:16:07, Bernhard Bauer wrote:
> SetString() here.

Done.

https://codereview.chromium.org/501063002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/website_settings_handler.cc:416:
Profile::FromWebUI(web_ui()))->GetPowerForOrigin(site_url);
On 2014/08/26 08:16:08, Bernhard Bauer wrote:
> Indent just four spaces w/r/t the preceding line.

Done.

[Bernhard Bauer, 2014-08-27 07:35:26]

lgtm

[Daniel Nishi, 2014-08-27 15:49:54]

The CQ bit was checked by dhnishi@chromium.org

[commit-bot: I haz the power, 2014-08-27 15:50:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dhnishi@chromium.org/501063002/100001

[commit-bot: I haz the power, 2014-08-27 15:59:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47034)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/52393)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-27 16:00:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 16:00:49]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Daniel Nishi, 2014-08-27 17:28:52]

The CQ bit was checked by dhnishi@chromium.org

[commit-bot: I haz the power, 2014-08-27 17:29:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dhnishi@chromium.org/501063002/120001

[commit-bot: I haz the power, 2014-08-27 18:31:24]

Committed patchset #3 (id:120001) as 8c4fd9750aba8243bdf37b178849b0bc6cbfb2b2

[commit-bot: I haz the power, 2014-09-10 02:52:55]

Patchset 3 (id:??) landed as
https://crrev.com/eda5899ef0421aa552c7b76eb87bb195b4fb1822
Cr-Commit-Position: refs/heads/master@{#292190}