content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc - Issue 501033003: Remove implicit conversions from scoped_refptr to T* in content/browser/renderer_host/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc

Issue 501033003: Remove implicit conversions from scoped_refptr to T* in content/browser/renderer_host/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/video_capture_host_unittest.cc ('k') | content/browser/renderer_host/pepper/pepper_file_system_browser_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc

diff --git a/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc b/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc

index 65c33b0aa9311d799b97f1d7cce571d394c1adfc..9a88cfc460a55557f0562604205c0ec600462840 100644

--- a/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc

+++ b/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc

@@ -258,7 +258,7 @@ ContentBrowserPepperHostFactory::CreateNewTCPSocket(

scoped_refptr<ResourceMessageFilter> tcp_socket(

new PepperTCPSocketMessageFilter(this, host_, instance, version));

- if (!tcp_socket)

+ if (!tcp_socket.get())

return scoped_ptr<ResourceHost>();

return scoped_ptr<ResourceHost>(new MessageFilterHost(