Issue 501011: Speculative fix for a chrome browser crash which occurs with ChromeFrame. Bas...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 501011: Speculative fix for a chrome browser crash which occurs with ChromeFrame. Bas... (Closed)

Created:
11 years ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Speculative fix for a chrome browser crash which occurs with ChromeFrame. Based on the crash dump, the crash occurs when the external tab container is being destroyed which in turn takes down the automation provider and the channel, etc. All this occurs in the context of OleUninitialize, which executes after BrowserMain returns, i.e. the message loop is now invalid, thus causing a crash while attempting to post a task to it. Based on this call stack it looks like it happens due to the enable-renderer-accessisibility flag. Fix is to move the OleInitialize/OleUnitialize calls to Platform::WillInitializeMainMessageLoop and Platform::DidEndMainMessageLoop. The Platform::DidEndMainMessageLoop function now executes as a task which is posted to the message loop prior to quitting it. This would ensure that the cleanup happens correctly. Fixes http://code.google.com/p/chromium/issues/detail?id=30383 Bug=30383 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34611

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -18 lines)			Patch
M	chrome/app/chrome_dll_main.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_main_win.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_process_impl.h	View	1	1 chunk	+2 lines, -14 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	1	2 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM if all tests still pass.

Expand Messages | Collapse Messages