Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 500963002: Revert of Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again. (Closed)

Created:
6 years, 4 months ago by pauljensen
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Revert of Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again. (patchset #2 of https://codereview.chromium.org/254713004/) Reason for revert: Still failing: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/52254/steps/content_browsertests/logs/CanMakeEmptyCallThenAddStreamsAndRenegotiate Original issue's description: > Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again. > The underalying problem is now fixed. See http://crbug/293125 and https://code.google.com/p/webrtc/source/detail?r=5870 > > BUG=293125, 362431 > > Committed: https://chromium.googlesource.com/chromium/src/+/b9a00c2caf679dfd2e97a3d6bbfd5e214609e1fc TBR=perkj NOTRY=true Committed: https://crrev.com/147bd4c5f34d80b5ac680db55a3d2d092788a7b9 Cr-Commit-Position: refs/heads/master@{#291671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pauljensen
Created Revert of Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again.
6 years, 4 months ago (2014-08-25 12:31:14 UTC) #1
pauljensen
The CQ bit was checked by pauljensen@chromium.org
6 years, 4 months ago (2014-08-25 12:32:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pauljensen@chromium.org/500963002/1
6 years, 4 months ago (2014-08-25 12:33:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (1) as ace0d03a7d599080582712704438086805dcfcd9
6 years, 4 months ago (2014-08-25 12:33:47 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:34:08 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/147bd4c5f34d80b5ac680db55a3d2d092788a7b9
Cr-Commit-Position: refs/heads/master@{#291671}

Powered by Google App Engine
This is Rietveld 408576698