Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 50093: Fix LayoutTests/http/tests/misc/url-in-utf16be.html and LayoutTests/http/test... (Closed)

Created:
11 years, 9 months ago by nicothakis
Modified:
9 years, 7 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix LayoutTests/http/tests/misc/url-in-utf16be.html and LayoutTests/http/tests/misc/url-in-utf16le.html This effectively reverts WebKit change 41727. If `this` is an UTF16-encoding, change 41727 caused wrong results. Since isNonByteBasedEncoding() checks noExtendedTextEncodingNameUsed() already, and boolean operators are lazy, reverting 41727 does not cause any harm but fixes the regression. http://crbug.com/9067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/WebCore/platform/text/TextEncoding.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nicothakis
Hi Jungshik, sending this your way since you created the test case this fixes. Since ...
11 years, 9 months ago (2009-03-22 18:51:35 UTC) #1
nicothakis
11 years, 9 months ago (2009-03-23 05:12:54 UTC) #2
Nevermind, I was just educated that this fix belongs into WebKit. I'm trying to
get this into WebKit at https://bugs.webkit.org/show_bug.cgi?id=24755 .

Powered by Google App Engine
This is Rietveld 408576698