Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 500923002: x87: Move IC code into a subdir and move ic-compilation related code from stub-cache into ic-compil… (Closed)

Created:
6 years, 4 months ago by chunyang.dai
Modified:
6 years, 4 months ago
Reviewers:
Weiliang, Toon Verwaest
CC:
v8-dev, danno
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

x87: Move IC code into a subdir and move ic-compilation related code from stub-cache into ic-compiler port r23306. original commit message: Move IC code into a subdir and move ic-compilation related code from stub-cache into ic-compiler. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -2784 lines) Patch
A + src/ic/x87/ic-compiler-x87.cc View 20 chunks +36 lines, -234 lines 0 comments Download
A + src/ic/x87/ic-x87.cc View 31 chunks +77 lines, -140 lines 0 comments Download
A + src/ic/x87/stub-cache-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/code-stubs-x87.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/codegen-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/x87/ic-x87.cc View 1 chunk +0 lines, -1211 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D src/x87/stub-cache-x87.cc View 1 chunk +0 lines, -1186 lines 0 comments Download
M test/cctest/test-disasm-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
chunyang.dai
weiliang. please review this patch. thanks.
6 years, 4 months ago (2014-08-25 05:51:36 UTC) #1
Weiliang
LGTM, But we still need Toon's review. Hi Toon, PTAL
6 years, 4 months ago (2014-08-25 06:58:22 UTC) #2
Toon Verwaest
lgtm
6 years, 4 months ago (2014-08-25 08:35:44 UTC) #3
Weiliang
6 years, 4 months ago (2014-08-25 09:01:50 UTC) #4
Committed as r23339

Powered by Google App Engine
This is Rietveld 408576698