Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 500823002: DevTools: set extension name as human-readable name of isolated world (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: set extension name as human-readable name of isolated world The patch sets up human-readable name of isolated worlds, generated by extension, to the name of the parent extension. This will be very useful for extension debugging in developer tools. BUG=160977 R=vsevik, yurys Committed: https://crrev.com/b53144f3c6a8d6e1fcafa4da544aed75e7b94322 Cr-Commit-Position: refs/heads/master@{#293095}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M extensions/renderer/script_injection.cc View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (2 generated)
lushnikov
PTAL This is a chromium-side of the patch. The blink side: https://codereview.chromium.org/15764004/
6 years, 4 months ago (2014-08-23 20:49:30 UTC) #1
yurys
lgtm https://codereview.chromium.org/500823002/diff/1/extensions/renderer/script_injection.cc File extensions/renderer/script_injection.cc (right): https://codereview.chromium.org/500823002/diff/1/extensions/renderer/script_injection.cc#newcode87 extensions/renderer/script_injection.cc:87: frame->setIsolatedWorldHumanReadableName( Should it be added to translate_helper.cc as ...
6 years, 4 months ago (2014-08-25 09:25:52 UTC) #2
lushnikov
https://codereview.chromium.org/500823002/diff/1/extensions/renderer/script_injection.cc File extensions/renderer/script_injection.cc (right): https://codereview.chromium.org/500823002/diff/1/extensions/renderer/script_injection.cc#newcode87 extensions/renderer/script_injection.cc:87: frame->setIsolatedWorldHumanReadableName( On 2014/08/25 09:25:52, yurys(OOO) wrote: > Should it ...
6 years, 3 months ago (2014-08-30 18:19:00 UTC) #3
lushnikov
@rockot, could you please take a look on the patch?
6 years, 3 months ago (2014-08-30 18:21:24 UTC) #5
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-02 22:55:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/500823002/1
6 years, 3 months ago (2014-09-03 05:35:17 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-03 06:34:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as a4986fbea875aa0bf7fb5aaa24efaef79b564fb3
6 years, 3 months ago (2014-09-03 07:44:49 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b53144f3c6a8d6e1fcafa4da544aed75e7b94322
Cr-Commit-Position: refs/heads/master@{#293095}

Powered by Google App Engine
This is Rietveld 408576698