Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: pkg/scheduled_test/lib/src/schedule.dart

Issue 50073007: fix barback and polymer build warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/scheduled_test/lib/src/schedule.dart
diff --git a/pkg/scheduled_test/lib/src/schedule.dart b/pkg/scheduled_test/lib/src/schedule.dart
index a4916967d8e8d30568dadb2e1016a0e0f8b5d680..5c88464b8d8d552f187f1904eba7aa5beda9d303 100644
--- a/pkg/scheduled_test/lib/src/schedule.dart
+++ b/pkg/scheduled_test/lib/src/schedule.dart
@@ -439,7 +439,7 @@ class TaskQueue {
return Future.forEach(_contents, (task) {
_schedule._currentTask = task;
if (_error != null) throw _error;
- if (_aborted) return;
+ if (_aborted) return null;
_taskFuture = new SubstituteFuture(task.fn());
return _taskFuture.whenComplete(() {
@@ -458,7 +458,7 @@ class TaskQueue {
_onTasksCompleteCompleter.completeError(e, stackTrace);
throw e;
}).whenComplete(() {
- if (pendingCallbacks.isEmpty) return;
+ if (pendingCallbacks.isEmpty) return null;
return _noPendingCallbacks.catchError((e, stackTrace) {
// Signal the error rather than passing it through directly so that if a
// timeout happens after an in-task error, both are reported.
@@ -518,7 +518,7 @@ class TaskQueue {
_schedule.signalError(error);
}
} finally {
- if (_timedOut()) return;
+ if (_timedOut()) return null;
_pendingCallbacks.remove(pendingCallback);
if (_pendingCallbacks.isEmpty && !isRunningTasks) {

Powered by Google App Engine
This is Rietveld 408576698