Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 50073005: Handlify concat string and substring. (Closed)

Created:
7 years, 1 month ago by Yang
Modified:
7 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Handlify concat string and substring. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17490

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -331 lines) Patch
M src/factory.h View 1 chunk +12 lines, -7 lines 0 comments Download
M src/factory.cc View 1 3 chunks +205 lines, -13 lines 0 comments Download
M src/handles.h View 1 chunk +1 line, -1 line 0 comments Download
M src/handles.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -19 lines 0 comments Download
M src/heap.cc View 1 chunk +0 lines, -256 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/runtime.cc View 4 chunks +17 lines, -19 lines 0 comments Download
M test/mjsunit/string-slices.js View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
7 years, 1 month ago (2013-10-29 13:03:03 UTC) #1
Yang
On 2013/10/29 13:03:03, Yang wrote: added write barrier skip check.
7 years, 1 month ago (2013-10-29 13:46:52 UTC) #2
ulan
LGTM
7 years, 1 month ago (2013-10-29 13:52:18 UTC) #3
Yang
7 years, 1 month ago (2013-11-05 14:07:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r17490 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698