Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: Source/bindings/tests/results/V8TestEventConstructor.h

Issue 50073004: We don't need to pass |creationContext| to v8SetReturnValue family (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestEvent.h ('k') | Source/bindings/tests/results/V8TestEventTarget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestEventConstructor.h
diff --git a/Source/bindings/tests/results/V8TestEventConstructor.h b/Source/bindings/tests/results/V8TestEventConstructor.h
index 409e4bb128192bfdea6ad0514a671ab88c57b789..fb67d9ab692f8035e9df2d0bb60cdcfb387f08a1 100644
--- a/Source/bindings/tests/results/V8TestEventConstructor.h
+++ b/Source/bindings/tests/results/V8TestEventConstructor.h
@@ -83,7 +83,7 @@ inline v8::Handle<v8::Value> toV8(TestEventConstructor* impl, v8::Handle<v8::Obj
}
template<typename CallbackInfo>
-inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestEventConstructor* impl, v8::Handle<v8::Object> creationContext)
+inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestEventConstructor* impl)
{
if (UNLIKELY(!impl)) {
v8SetReturnValueNull(callbackInfo);
@@ -91,12 +91,12 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestEventConstruc
}
if (DOMDataStore::setReturnValueFromWrapper<V8TestEventConstructor>(callbackInfo.GetReturnValue(), impl))
return;
- v8::Handle<v8::Object> wrapper = wrap(impl, creationContext, callbackInfo.GetIsolate());
+ v8::Handle<v8::Object> wrapper = wrap(impl, callbackInfo.Holder(), callbackInfo.GetIsolate());
v8SetReturnValue(callbackInfo, wrapper);
}
template<typename CallbackInfo>
-inline void v8SetReturnValueForMainWorld(const CallbackInfo& callbackInfo, TestEventConstructor* impl, v8::Handle<v8::Object> creationContext)
+inline void v8SetReturnValueForMainWorld(const CallbackInfo& callbackInfo, TestEventConstructor* impl)
{
ASSERT(worldType(callbackInfo.GetIsolate()) == MainWorld);
if (UNLIKELY(!impl)) {
@@ -105,7 +105,7 @@ inline void v8SetReturnValueForMainWorld(const CallbackInfo& callbackInfo, TestE
}
if (DOMDataStore::setReturnValueFromWrapperForMainWorld<V8TestEventConstructor>(callbackInfo.GetReturnValue(), impl))
return;
- v8::Handle<v8::Value> wrapper = wrap(impl, creationContext, callbackInfo.GetIsolate());
+ v8::Handle<v8::Value> wrapper = wrap(impl, callbackInfo.Holder(), callbackInfo.GetIsolate());
v8SetReturnValue(callbackInfo, wrapper);
}
@@ -128,15 +128,15 @@ inline v8::Handle<v8::Value> toV8(PassRefPtr<TestEventConstructor > impl, v8::Ha
}
template<class CallbackInfo>
-inline void v8SetReturnValue(const CallbackInfo& callbackInfo, PassRefPtr<TestEventConstructor > impl, v8::Handle<v8::Object> creationContext)
+inline void v8SetReturnValue(const CallbackInfo& callbackInfo, PassRefPtr<TestEventConstructor > impl)
{
- v8SetReturnValue(callbackInfo, impl.get(), creationContext);
+ v8SetReturnValue(callbackInfo, impl.get());
}
template<class CallbackInfo>
-inline void v8SetReturnValueForMainWorld(const CallbackInfo& callbackInfo, PassRefPtr<TestEventConstructor > impl, v8::Handle<v8::Object> creationContext)
+inline void v8SetReturnValueForMainWorld(const CallbackInfo& callbackInfo, PassRefPtr<TestEventConstructor > impl)
{
- v8SetReturnValueForMainWorld(callbackInfo, impl.get(), creationContext);
+ v8SetReturnValueForMainWorld(callbackInfo, impl.get());
}
template<class CallbackInfo, class Wrappable>
« no previous file with comments | « Source/bindings/tests/results/V8TestEvent.h ('k') | Source/bindings/tests/results/V8TestEventTarget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698