Source/bindings/tests/results/V8SupportTestInterface.cpp - Issue 50073004: We don't need to pass |creationContext| to v8SetReturnValue family

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8SupportTestInterface.cpp

Issue 50073004: We don't need to pass |creationContext| to v8SetReturnValue family (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8SupportTestInterface.cpp

diff --git a/Source/bindings/tests/results/V8SupportTestInterface.cpp b/Source/bindings/tests/results/V8SupportTestInterface.cpp

index a7ae71f953a391f4c4b31d9096d9d7d3d09b62b7..be6f81e45ce5807c085ed381b70c211cde4ccfee 100644

--- a/Source/bindings/tests/results/V8SupportTestInterface.cpp

+++ b/Source/bindings/tests/results/V8SupportTestInterface.cpp

@@ -327,7 +327,7 @@ static void supplementalMethod2Method(const v8::FunctionCallbackInfo<v8::Value>&

RefPtr<TestObj> result = SupportTestPartialInterface::supplementalMethod2(scriptContext, imp, strArg, objArg, es);

if (es.throwIfNeeded())

return;

- v8SetReturnValue(args, result.release(), args.Holder());

+ v8SetReturnValue(args, result.release());

}

#endif // ENABLE(Condition11) || ENABLE(Condition12)