Fix crash on Linux when a normal window is created after a hidden window.

chrome/browser/apps/app_crashtest.cc

Index: chrome/browser/apps/app_crashtest.cc
diff --git a/chrome/browser/apps/app_crashtest.cc b/chrome/browser/apps/app_crashtest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..15670ed7dce49dd3b575b78a318277758911da91
--- /dev/null
+++ b/chrome/browser/apps/app_crashtest.cc
@@ -0,0 +1,36 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/apps/app_browsertest_util.h"
+#include "chrome/browser/extensions/extension_test_message_listener.h"
+
+using namespace apps;
+
+namespace extensions {

[benwells, 2013/10/29 21:22:34]

no namespace here. we have some clear but not-always-followed rules for
namespaces:
- top level components have their own namespace
- except for chrome which isn't really a namespace
- apart from that namespaces can be used for encapsulation but this is rare.

The extensions namespace is a bit wrong, as it is used for stuff in the top
level extensions component and also for stuff in c/*/extensions. This file is in
neither though..

+
+// This class of BrowserTests is a helper to create tests related to crashes in
+// Chrome Apps. To be tested, the app will have to be placed as any other test
+// app (see PlatformAppBrowserTest) and will need to send a "Done" message back.
+// When the "Done" message is received, the test succeed. If it is not, it is
+// assumed that Chrome has crashed and the test will anyway fail.
+//
+// The entry in this file should be something like:
+// IN_PROC_BROWSER_TEST_F(AppCrashTest, <TEST_NAME>) {
+//   ASSERT_TRUE(RunAppCrashTest("<DIRECTORY_TEST_NAME>"));
+// }
+
+class AppCrashTest : public PlatformAppBrowserTest {
+public:
+  bool RunAppCrashTest(const char* name) {
+    ExtensionTestMessageListener listener("Done", false);
+    LoadAndLaunchPlatformApp(name);
+    return listener.WaitUntilSatisfied();
+  }
+};
+
+IN_PROC_BROWSER_TEST_F(AppCrashTest, HiddenWindows) {
+  ASSERT_TRUE(RunAppCrashTest("crashtest_hidden_windows"));
+}
+
+} // namespace extensions