Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 500713002: Fix linking issue for Chromium Browser with Ozone build. (Closed)

Created:
6 years, 4 months ago by kalyank
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GuessWindowManager is defined only on x11 platform. This CL changes the platform check from Linux to X11. Committed: https://crrev.com/cc2b327bf14ae585424208391fe72f03a860bd83 Cr-Commit-Position: refs/heads/master@{#291612}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Include x11_utils only on x11 platform #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kalyank
6 years, 4 months ago (2014-08-23 06:11:48 UTC) #1
Alexei Svitkine (slow)
LGTM https://codereview.chromium.org/500713002/diff/1/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc File chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc (right): https://codereview.chromium.org/500713002/diff/1/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc#newcode33 chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc:33: #include "ui/base/x/x11_util.h" Nit: Should this check the X11 ...
6 years, 4 months ago (2014-08-23 15:18:33 UTC) #2
kondapallykalyan
https://codereview.chromium.org/500713002/diff/1/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc File chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc (right): https://codereview.chromium.org/500713002/diff/1/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc#newcode33 chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc:33: #include "ui/base/x/x11_util.h" On 2014/08/23 15:18:32, Alexei Svitkine wrote: > ...
6 years, 4 months ago (2014-08-23 18:20:57 UTC) #3
kalyank_
The CQ bit was checked by kalyan.kondapally@chromium.org
6 years, 4 months ago (2014-08-23 22:47:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalyan.kondapally@intel.com/500713002/20001
6 years, 4 months ago (2014-08-23 22:48:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (20001) as dcf9be6e1f664fd09b38a00f96534b353d18f3f1
6 years, 4 months ago (2014-08-23 23:31:11 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:32:12 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cc2b327bf14ae585424208391fe72f03a860bd83
Cr-Commit-Position: refs/heads/master@{#291612}

Powered by Google App Engine
This is Rietveld 408576698