Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/renderer/render_view.cc

Issue 50067: Fix renderer crash when a file chooser is closed after navigating away from... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view.cc
===================================================================
--- chrome/renderer/render_view.cc (revision 12184)
+++ chrome/renderer/render_view.cc (working copy)
@@ -2608,6 +2608,11 @@
void RenderView::OnFileChooserResponse(
const std::vector<std::wstring>& file_names) {
+ // This could happen if we navigated to a different page before the user
+ // closed the chooser.
+ if (!file_chooser_.get())
+ return;
+
file_chooser_->OnFileChoose(file_names);
file_chooser_.reset();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698