Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 500653003: Video capture frame size: separate coded size and visible size. (Closed)

Created:
6 years, 4 months ago by hshi1
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/e79241d8e2f7f17ea1c55fbb3c26674527bd58cd Cr-Commit-Position: refs/heads/master@{#292717}

Patch Set 1 #

Patch Set 2 : Remove the workaround for Chrome OS. #

Patch Set 3 : Fix content_unittests build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -29 lines) Patch
M content/browser/media/capture/content_video_capture_device_core.cc View 1 2 chunks +10 lines, -5 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 1 1 chunk +3 lines, -10 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_event_handler.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 4 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 2 6 chunks +7 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/common/media/video_capture_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/video_capture_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/media/video_capture_message_filter_unittest.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (1 generated)
hshi1
hshi@chromium.org changed reviewers: + hclam@chromium.org
6 years, 3 months ago (2014-08-28 22:49:26 UTC) #1
hshi1
Alpha: PTAL. I've added plumbing in the capture pipeline to forward the visible rect to ...
6 years, 3 months ago (2014-08-28 22:49:26 UTC) #2
hshi1
hshi@chromium.org changed reviewers: + dalecurtis@chromium.org, palmer@chromium.org
6 years, 3 months ago (2014-08-29 00:13:56 UTC) #3
hshi1
+dalecurtis (OWNER of */media) +palmer (OWNER of *_messages*.h)
6 years, 3 months ago (2014-08-29 00:13:56 UTC) #4
Alpha Left Google
LGTM.
6 years, 3 months ago (2014-08-29 18:11:06 UTC) #5
Alpha Left Google
On 2014/08/29 18:11:06, Alpha wrote: > LGTM. Please use bug 402501 instead.
6 years, 3 months ago (2014-08-29 18:13:30 UTC) #6
palmer
lgtm
6 years, 3 months ago (2014-08-29 18:31:49 UTC) #7
DaleCurtis
rslgtm
6 years, 3 months ago (2014-08-29 20:12:24 UTC) #8
DaleCurtis
err, rs lgtm i guess these days.
6 years, 3 months ago (2014-08-29 20:12:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/500653003/40001
6 years, 3 months ago (2014-08-29 22:00:04 UTC) #11
hshi1
Committed patchset #3 (id:40001) to pending queue manually as 27b2f06 (presubmit successful).
6 years, 3 months ago (2014-08-29 23:35:59 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:11:43 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e79241d8e2f7f17ea1c55fbb3c26674527bd58cd
Cr-Commit-Position: refs/heads/master@{#292717}

Powered by Google App Engine
This is Rietveld 408576698