Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 500623002: Use TimeTicks::Now() instead of Time::Now() in upgrade detector. (Closed)

Created:
6 years, 4 months ago by Alexei Svitkine (slow)
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Use TimeTicks::Now() instead of Time::Now() in upgrade detector. BUG=400472 Committed: https://crrev.com/5d4db6bfc037d69528891d6ed1fe6739e02b3d64 Cr-Commit-Position: refs/heads/master@{#291793}

Patch Set 1 : #

Patch Set 2 : Fix type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/upgrade_detector_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Alexei Svitkine (slow)
6 years, 4 months ago (2014-08-22 20:59:32 UTC) #1
sky
Don't you need to change the member to TimeTicks too?
6 years, 4 months ago (2014-08-22 22:33:19 UTC) #2
Alexei Svitkine (slow)
On 2014/08/22 22:33:19, sky wrote: > Don't you need to change the member to TimeTicks ...
6 years, 4 months ago (2014-08-25 20:38:14 UTC) #3
sky
LGTM
6 years, 4 months ago (2014-08-25 20:55:44 UTC) #4
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 4 months ago (2014-08-25 20:58:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/500623002/40001
6 years, 4 months ago (2014-08-25 20:58:47 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-25 22:55:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (40001) as ee205324e5f180697eb13338492587d056b6c0a5
6 years, 4 months ago (2014-08-25 23:55:44 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:38:45 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d4db6bfc037d69528891d6ed1fe6739e02b3d64
Cr-Commit-Position: refs/heads/master@{#291793}

Powered by Google App Engine
This is Rietveld 408576698