Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 500613004: history: fix focus outline on bookmarks star. (Closed)

Created:
6 years, 3 months ago by Dan Beam
Modified:
6 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

history: fix focus outline on bookmarks star. R=estade@chromium.org BUG=407979 TEST=visual NOTRY=true Committed: https://crrev.com/796768e3fcff9f9dfa20574d528c485680cdc518 Cr-Commit-Position: refs/heads/master@{#293556}

Patch Set 1 : simpler #

Patch Set 2 : fixes #

Total comments: 3

Patch Set 3 : off, center! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/resources/history/history.css View 1 2 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Dan Beam
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-27 22:57:52 UTC) #1
Dan Beam
6 years, 3 months ago (2014-08-27 22:58:04 UTC) #2
Evan Stade
hmm I think this changes the clickable region. The curernt CSS is probably intentionally expanding ...
6 years, 3 months ago (2014-08-28 18:12:38 UTC) #3
Evan Stade
On 2014/08/28 18:12:38, Evan Stade wrote: > hmm I think this changes the clickable region. ...
6 years, 3 months ago (2014-09-03 21:59:47 UTC) #4
Dan Beam
estade@: ptal - added link outline fixes
6 years, 3 months ago (2014-09-05 00:48:33 UTC) #7
Evan Stade
I assume this is the code for the last imgur album you sent me --- ...
6 years, 3 months ago (2014-09-05 17:32:49 UTC) #8
Dan Beam
https://codereview.chromium.org/500613004/diff/80001/chrome/browser/resources/history/history.css File chrome/browser/resources/history/history.css (right): https://codereview.chromium.org/500613004/diff/80001/chrome/browser/resources/history/history.css#newcode495 chrome/browser/resources/history/history.css:495: background: no-repeat center center On 2014/09/05 17:32:48, Evan Stade ...
6 years, 3 months ago (2014-09-05 17:56:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/500613004/80001
6 years, 3 months ago (2014-09-05 17:58:21 UTC) #11
Dan Beam
https://codereview.chromium.org/500613004/diff/80001/chrome/browser/resources/history/history.css File chrome/browser/resources/history/history.css (right): https://codereview.chromium.org/500613004/diff/80001/chrome/browser/resources/history/history.css#newcode495 chrome/browser/resources/history/history.css:495: background: no-repeat center center On 2014/09/05 17:56:31, Dan Beam ...
6 years, 3 months ago (2014-09-05 18:04:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/500613004/100001
6 years, 3 months ago (2014-09-05 18:07:29 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:100001) as 1c6862870538aebc39454ecc744701624d8b3db7
6 years, 3 months ago (2014-09-05 18:10:55 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:40:46 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/796768e3fcff9f9dfa20574d528c485680cdc518
Cr-Commit-Position: refs/heads/master@{#293556}

Powered by Google App Engine
This is Rietveld 408576698