Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: chromeos/accelerometer/accelerometer_reader.h

Issue 500613003: Use standardized and extendable accelerometer update type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge and remove unused Vector3dF reference. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/accelerometer/accelerometer_reader.h
diff --git a/chromeos/accelerometer/accelerometer_reader.h b/chromeos/accelerometer/accelerometer_reader.h
index e2b85bcd4d8c4ca0768cc224b79eccb68057400e..c3c4efd7b9110662f76d1eef67bc6e97d0cd8045 100644
--- a/chromeos/accelerometer/accelerometer_reader.h
+++ b/chromeos/accelerometer/accelerometer_reader.h
@@ -11,7 +11,7 @@
#include "base/memory/weak_ptr.h"
#include "base/observer_list.h"
#include "chromeos/chromeos_export.h"
-#include "ui/gfx/geometry/vector3d_f.h"
+#include "ui/accelerometer/accelerometer_types.h"
namespace base {
class TaskRunner;
@@ -41,8 +41,8 @@ class CHROMEOS_EXPORT AccelerometerReader {
// An interface to receive data from the AccelerometerReader.
class Delegate {
public:
- virtual void HandleAccelerometerReading(const gfx::Vector3dF& base,
- const gfx::Vector3dF& lid) = 0;
+ virtual void HandleAccelerometerUpdate(
+ const ui::AccelerometerUpdate& update) = 0;
};
AccelerometerReader(base::TaskRunner* blocking_task_runner,
@@ -58,8 +58,8 @@ class CHROMEOS_EXPORT AccelerometerReader {
// OnDataRead with the result.
void TriggerRead();
- // If |success|, converts the raw reading to a pair of Vector3dF
- // values and notifies the |delegate_| with the new readings.
+ // If |success|, converts the raw reading to an AccelerometerUpdate
+ // message and notifies the |delegate_| with the new readings.
// Triggers another read from the accelerometer at the current sampling rate.
void OnDataRead(scoped_refptr<Reading> reading, bool success);
@@ -69,6 +69,9 @@ class CHROMEOS_EXPORT AccelerometerReader {
// A weak pointer to the delegate to send accelerometer readings to.
Delegate* delegate_;
+ // The last seen accelerometer data.
+ ui::AccelerometerUpdate update_;
+
// The accelerometer configuration.
scoped_refptr<Configuration> configuration_;

Powered by Google App Engine
This is Rietveld 408576698