Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: chrome/browser/chromeos/display/display_preferences_unittest.cc

Issue 500613003: Use standardized and extendable accelerometer update type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge and remove unused Vector3dF reference. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/display/display_preferences_unittest.cc
diff --git a/chrome/browser/chromeos/display/display_preferences_unittest.cc b/chrome/browser/chromeos/display/display_preferences_unittest.cc
index 31ff620353227eadbd0a0f091bad4244711490f0..0f17f5d3c05fcf3d5f22352a23d7779f41212e74 100644
--- a/chrome/browser/chromeos/display/display_preferences_unittest.cc
+++ b/chrome/browser/chromeos/display/display_preferences_unittest.cc
@@ -38,6 +38,9 @@ const char kMirroredKey[] = "mirrored";
const char kPositionKey[] = "position";
const char kOffsetKey[] = "offset";
+// The mean acceleration due to gravity on Earth in m/s^2.
+const float kMeanGravity = 9.80665f;
+
class DisplayPreferencesTest : public ash::test::AshTestBase {
protected:
DisplayPreferencesTest()
@@ -663,13 +666,20 @@ TEST_F(DisplayPreferencesTest, DontSaveMaximizeModeControllerRotations) {
gfx::Display::ROTATE_0);
// Open up 270 degrees to trigger maximize mode
- controller->OnAccelerometerUpdated(gfx::Vector3dF(0.0f, 0.0f, -1.0f),
- gfx::Vector3dF(-1.0f, 0.0f, 0.0f));
+ ui::AccelerometerUpdate update;
+ update.Set(ui::ACCELEROMETER_SOURCE_ATTACHED_KEYBOARD,
+ 0.0f, 0.0f, kMeanGravity);
+ update.Set(ui::ACCELEROMETER_SOURCE_SCREEN,
+ 0.0f, -kMeanGravity, 0.0f);
+ controller->OnAccelerometerUpdated(update);
EXPECT_TRUE(controller->IsMaximizeModeWindowManagerEnabled());
// Trigger 90 degree rotation
- controller->OnAccelerometerUpdated(gfx::Vector3dF(0.0f, 1.0f, 0.0f),
- gfx::Vector3dF(0.0f, 1.0f, 0.0f));
+ update.Set(ui::ACCELEROMETER_SOURCE_ATTACHED_KEYBOARD,
+ -kMeanGravity, 0.0f, 0.0f);
+ update.Set(ui::ACCELEROMETER_SOURCE_SCREEN,
+ -kMeanGravity, 0.0f, 0.0f);
+ controller->OnAccelerometerUpdated(update);
EXPECT_EQ(gfx::Display::ROTATE_90, display_manager->
GetDisplayInfo(gfx::Display::InternalDisplayId()).rotation());
@@ -799,9 +809,12 @@ TEST_F(DisplayPreferencesTest, LoadRotationNoLogin) {
EXPECT_EQ(gfx::Display::ROTATE_0, before_maximize_mode_rotation);
// Open up 270 degrees to trigger maximize mode
- maximize_mode_controller->
- OnAccelerometerUpdated(gfx::Vector3dF(0.0f, 0.0f, -1.0f),
- gfx::Vector3dF(-1.0f, 0.0f, 0.0f));
+ ui::AccelerometerUpdate update;
+ update.Set(ui::ACCELEROMETER_SOURCE_ATTACHED_KEYBOARD,
+ 0.0f, 0.0f, kMeanGravity);
+ update.Set(ui::ACCELEROMETER_SOURCE_SCREEN,
+ 0.0f, -kMeanGravity, 0.0f);
+ maximize_mode_controller->OnAccelerometerUpdated(update);
EXPECT_TRUE(maximize_mode_controller->IsMaximizeModeWindowManagerEnabled());
bool maximize_mode_rotation_lock =
maximize_mode_controller->rotation_locked();
@@ -826,16 +839,21 @@ TEST_F(DisplayPreferencesTest, LoadRotationIgnoredInNormalMode) {
ash::MaximizeModeController* maximize_mode_controller =
ash::Shell::GetInstance()->maximize_mode_controller();
// Lid open to 90 degrees
- maximize_mode_controller->
- OnAccelerometerUpdated(gfx::Vector3dF(0.0f, 0.0f, 1.0f),
- gfx::Vector3dF(-1.0f, 0.0f, 0.0f));
+ ui::AccelerometerUpdate update;
+ update.Set(ui::ACCELEROMETER_SOURCE_ATTACHED_KEYBOARD,
+ -kMeanGravity, 0.0f, 0.0f);
+ update.Set(ui::ACCELEROMETER_SOURCE_SCREEN,
+ -kMeanGravity, 0.0f, 0.0f);
+ maximize_mode_controller->OnAccelerometerUpdated(update);
EXPECT_FALSE(maximize_mode_controller->IsMaximizeModeWindowManagerEnabled());
EXPECT_FALSE(maximize_mode_controller->rotation_locked());
// Open up 270 degrees to trigger maximize mode
- maximize_mode_controller->
- OnAccelerometerUpdated(gfx::Vector3dF(0.0f, 0.0f, -1.0f),
- gfx::Vector3dF(-1.0f, 0.0f, 0.0f));
+ update.Set(ui::ACCELEROMETER_SOURCE_ATTACHED_KEYBOARD,
+ 0.0f, 0.0f, kMeanGravity);
+ update.Set(ui::ACCELEROMETER_SOURCE_SCREEN,
+ 0.0f, -kMeanGravity, 0.0f);
+ maximize_mode_controller->OnAccelerometerUpdated(update);
EXPECT_TRUE(maximize_mode_controller->IsMaximizeModeWindowManagerEnabled());
EXPECT_FALSE(maximize_mode_controller->rotation_locked());
}

Powered by Google App Engine
This is Rietveld 408576698