chromeos/DEPS - Issue 500613003: Use standardized and extendable accelerometer update type.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/DEPS

Issue 500613003: Use standardized and extendable accelerometer update type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge and remove unused Vector3dF reference. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+crypto",	2 "+crypto",

3 "+net",	3 "+net",

4 "+policy/proto",	4 "+policy/proto",

5 "+third_party/cros_system_api",	5 "+third_party/cros_system_api",

6 "+third_party/libxml",	6 "+third_party/libxml",

7 "+third_party/protobuf",	7 "+third_party/protobuf",

8 "+ui/gfx/geometry",	8 "+ui/accelerometer",
	stevenjb 2014/11/06 16:38:37 I just ran across this and have to say I am not a I just ran across this and have to say I am not a fan of having ui/ dependencies in chromeos/. The intention of chromeos/ was to be a low level system library, any dependencies should be the other way around. Is there an easy way to fix this? flackr 2014/11/06 16:54:01 We could have a special type for the updates retur Show quoted text On 2014/11/06 16:38:37, stevenjb wrote: > I just ran across this and have to say I am not a fan of having ui/ dependencies > in chromeos/. The intention of chromeos/ was to be a low level system library, > any dependencies should be the other way around. Is there an easy way to fix > this? We could have a special type for the updates returned from chromeos/ and then translate to some other type in ash/accelerometer/accelerometer_reader, but duplicating all of the information in the type seems suboptimal. Are there any better suited locations for defining a common type we want to share between chromeos/ and ui code?
9 "+ui/gfx/x"	9 "+ui/gfx/x"

10 ]	10 ]

OLD	NEW

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chromeos/accelerometer/accelerometer_reader.h » ('j') | no next file with comments »