Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 500593002: mojo: Fixed mojo_example_apptests. (Closed)

Created:
6 years, 4 months ago by alokp
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

mojo: Fixed mojo_example_apptests. It broke in r291039. Committed: https://crrev.com/d009777fa2991cbe951bb477d9a7414d1baef22a Cr-Commit-Position: refs/heads/master@{#291710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M mojo/examples/apptest/example_service_application.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
alokp
We do not have these tests running on bots?
6 years, 4 months ago (2014-08-22 19:02:49 UTC) #1
msw
Thanks, lgtm. I'll look into getting these running on bots. (I've never actually added a ...
6 years, 4 months ago (2014-08-22 19:09:14 UTC) #2
alokp
davemoore: OWNER blessing.
6 years, 4 months ago (2014-08-22 19:11:47 UTC) #3
DaveMoore
lgtm
6 years, 4 months ago (2014-08-22 19:41:53 UTC) #4
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 4 months ago (2014-08-22 20:18:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/500593002/1
6 years, 4 months ago (2014-08-22 20:20:36 UTC) #6
tim (not reviewing)
Oops. Thanks.
6 years, 4 months ago (2014-08-22 20:50:43 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 21:37:23 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 22:43:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1574)
6 years, 4 months ago (2014-08-22 22:43:24 UTC) #10
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 4 months ago (2014-08-25 16:55:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/500593002/1
6 years, 4 months ago (2014-08-25 16:56:43 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (1) as 6d2bbf616c4808908adfd92f5686cbfc2dd0b663
6 years, 4 months ago (2014-08-25 17:52:22 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:33 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d009777fa2991cbe951bb477d9a7414d1baef22a
Cr-Commit-Position: refs/heads/master@{#291710}

Powered by Google App Engine
This is Rietveld 408576698