Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 500563002: Reorder GenerateStateFromBeaconAndAttemptCount. (Closed)

Created:
6 years, 4 months ago by csharp
Modified:
6 years, 3 months ago
Reviewers:
robertshield
CC:
chromium-reviews, caitkp+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Reorder GenerateStateFromBeaconAndAttemptCount. I think the older order could result in incorrect behavior if Chrome crashed during startup. This might help with the bug as well. BUG=406475 Committed: https://crrev.com/619b85aaed93f95207dc9c06fa85fe14cb91c101 Cr-Commit-Position: refs/heads/master@{#291679}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome_elf/blacklist/blacklist.cc View 2 chunks +9 lines, -11 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
csharp
I don't think this will fix the issue in the bug, but it does have ...
6 years, 4 months ago (2014-08-22 18:12:20 UTC) #1
robertshield
https://codereview.chromium.org/500563002/diff/1/chrome_elf/blacklist/blacklist.cc File chrome_elf/blacklist/blacklist.cc (left): https://codereview.chromium.org/500563002/diff/1/chrome_elf/blacklist/blacklist.cc#oldcode90 chrome_elf/blacklist/blacklist.cc:90: if (blacklist_state == blacklist::BLACKLIST_SETUP_RUNNING) { previously, BLACKLIST_STATE_FAILED would hit ...
6 years, 4 months ago (2014-08-25 13:40:18 UTC) #2
robertshield
as discussed, lgtm
6 years, 4 months ago (2014-08-25 13:45:08 UTC) #3
csharp
The CQ bit was checked by csharp@chromium.org
6 years, 4 months ago (2014-08-25 13:45:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/500563002/1
6 years, 4 months ago (2014-08-25 13:45:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 3de54bf82c5df15d9a587af10165cc7d7121ed30
6 years, 4 months ago (2014-08-25 14:38:07 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:34:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/619b85aaed93f95207dc9c06fa85fe14cb91c101
Cr-Commit-Position: refs/heads/master@{#291679}

Powered by Google App Engine
This is Rietveld 408576698